Skip to content

Conversation

silverwind
Copy link
Member

Drone can display terminal colors, so force-enable it to make diffs more readable on it.

Drone CI can display terminal colors, so force-enable it to make diffs
more readable on it.
@silverwind silverwind added this to the 1.20.0 milestone Mar 18, 2023
@silverwind silverwind added topic/gitea-actions related to the actions of Gitea type/enhancement An improvement of existing functionality labels Mar 18, 2023
@silverwind silverwind changed the title Enable color for diffs in consistency checks Enable color for consistency checks diffs Mar 18, 2023
@silverwind
Copy link
Member Author

Pushed a test commit so we can verify, will revert it later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2023
@silverwind
Copy link
Member Author

Color works:

image

There is no word highlight and that will require additional tools, but I'd say it's still an improvement over uncolored.

@silverwind silverwind added topic/code-linting and removed topic/gitea-actions related to the actions of Gitea labels Mar 18, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2023
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope we don't have anyone who runs these make commands on a non-color capable tty…

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 18, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) March 19, 2023 01:47
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick merged commit 847f854 into go-gitea:main Mar 19, 2023
@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 19, 2023
@silverwind silverwind deleted the colordiff branch March 19, 2023 19:10
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 20, 2023
* giteaofficial/main: (23 commits)
  Display the version of runner in the runner list (go-gitea#23490)
  Add `.patch` to `attachment.ALLOWED_TYPES` (go-gitea#23580)
  Sort Python package descriptors by version to mimic PyPI format (go-gitea#23550)
  Use `project.IconName` instead of repeated unreadable `if-else` chains (go-gitea#23538)
  Match api migration behavior to web behavior (go-gitea#23552)
  Fix dropdown icon misalignment when using fomantic icon (go-gitea#23558)
  Enable color for consistency checks diffs (go-gitea#23563)
  [skip ci] Updated translations via Crowdin
  Fix sticky header in diff view (go-gitea#23554)
  Fix some broken css (go-gitea#23560)
  Fix JS error on compare page (go-gitea#23551)
  Upgrade to npm lockfile v3 and explicitely set it (go-gitea#23561)
  Fix long name ui issues and label ui issue  (go-gitea#23541)
  Remove worker-loader (go-gitea#23548)
  [skip ci] Updated translations via Crowdin
  Return `repository` in npm package metadata endpoint (go-gitea#23539)
  Fix diff detail buttons wrapping, use tippy for review box (go-gitea#23271)
  Do not store user projects as organization projects (go-gitea#23353)
  Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (go-gitea#23513)
  Increase horizontal page padding (go-gitea#23507)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants