Skip to content

Fix some broken css #23560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2023
Merged

Fix some broken css #23560

merged 4 commits into from
Mar 18, 2023

Conversation

wxiaoguang
Copy link
Contributor

  1. The "close" inside "modal" are likely broken for long time
    • There is no var called --body-color
    • There is no fullscreen modal
    • The .ui.modal > .close.inside doesn't seem to match most icons. It only matches a few like "fork-repo-modal" or "adopt repo". Other places are just buggy code copied again and again.
  2. Convert the legacy &:hover LESS syntax to CSS syntax

@silverwind
Copy link
Member

There is no var called --body-color

We need a linter rule for undefined vars 😉

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 18, 2023
@silverwind
Copy link
Member

Should try https://github.com/csstools/stylelint-value-no-unknown-custom-properties.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023 •
edited
Loading

Codecov Report

Merging #23560 (39c99a2) into main (f521e88) will decrease coverage by 0.42%.
The diff coverage is 44.34%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23560      +/-   ##
==========================================
- Coverage   47.14%   46.72%   -0.42%     
==========================================
  Files        1149     1154       +5     
  Lines      151446   152264     +818     
==========================================
- Hits        71397    71150     -247     
- Misses      71611    72653    +1042     
- Partials     8438     8461      +23
Impacted Files Coverage Δ
cmd/dump.go 0.67% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.64% <0.00%> (-0.08%) ⬇️
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
models/user/search.go 77.50% <0.00%> (-6.29%) ⬇️
modules/actions/github.go 0.00% <0.00%> (ø)
modules/actions/workflows.go 0.00% <0.00%> (ø)
modules/doctor/storage.go 31.93% <0.00%> (ø)
modules/setting/git.go 45.45% <ø> (ø)
modules/storage/minio.go 1.51% <0.00%> (-0.06%) ⬇️
... and 50 more

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@silverwind
Copy link
Member

Convert the legacy &:hover LESS syntax to CSS syntax

Thanks for catching, I recall linebuttons.css was not ran through lessc. Another option would be to just run it through it now, but I assume it will yield the same output.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 18, 2023
@silverwind silverwind added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Mar 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 18, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 18, 2023
@silverwind
Copy link
Member

silverwind commented Mar 18, 2023 •
edited
Loading

FYI, I tested the stylelint plugin and it works, but we need to wait on csstools/stylelint-value-no-unknown-custom-properties#32 before we can integrate it.

web_src/css/base.css
 1179:14  ✖  Unexpected custom property "--body-color" inside          csstools/value-no-unknown-custom-properties
             declaration "color".

@delvh delvh added this to the 1.20.0 milestone Mar 18, 2023
@delvh delvh enabled auto-merge (squash) March 18, 2023 21:52
@delvh
Copy link
Member

delvh commented Mar 18, 2023

🎺 🤖

@delvh delvh merged commit 27fcfae into go-gitea:main Mar 18, 2023
@GiteaBot GiteaBot mentioned this pull request Mar 18, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 18, 2023
@wxiaoguang @GiteaBot
Fix some broken css (go-gitea#23560)
7764617 
1. The "close" inside "modal" are likely broken for long time
    * There is no var called `--body-color`
    * There is no `fullscreen modal`
* The `.ui.modal > .close.inside` doesn't seem to match most icons. It
only matches a few like "fork-repo-modal" or "adopt repo". Other places
are just buggy code copied again and again.
2. Convert the legacy `&:hover` LESS syntax to CSS syntax
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Mar 18, 2023
@delvh delvh removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 19, 2023
techknowlogick pushed a commit that referenced this pull request Mar 19, 2023
@GiteaBot @wxiaoguang @delvh
Fix some broken css (#23560) (#23567)
3f253b3 
Backport #23560 by @wxiaoguang

1. The "close" inside "modal" are likely broken for long time
    * There is no var called `--body-color`
    * There is no `fullscreen modal`
* The `.ui.modal > .close.inside` doesn't seem to match most icons. It
only matches a few like "fork-repo-modal" or "adopt repo". Other places
are just buggy code copied again and again.
2. Convert the legacy `&:hover` LESS syntax to CSS syntax

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <leon@kske.dev>
@wxiaoguang wxiaoguang deleted the fix-broken-css branch March 19, 2023 02:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 20, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
34dcc5c 
* giteaofficial/main: (23 commits)
  Display the version of runner in the runner list (go-gitea#23490)
  Add `.patch` to `attachment.ALLOWED_TYPES` (go-gitea#23580)
  Sort Python package descriptors by version to mimic PyPI format (go-gitea#23550)
  Use `project.IconName` instead of repeated unreadable `if-else` chains (go-gitea#23538)
  Match api migration behavior to web behavior (go-gitea#23552)
  Fix dropdown icon misalignment when using fomantic icon (go-gitea#23558)
  Enable color for consistency checks diffs (go-gitea#23563)
  [skip ci] Updated translations via Crowdin
  Fix sticky header in diff view (go-gitea#23554)
  Fix some broken css (go-gitea#23560)
  Fix JS error on compare page (go-gitea#23551)
  Upgrade to npm lockfile v3 and explicitely set it (go-gitea#23561)
  Fix long name ui issues and label ui issue  (go-gitea#23541)
  Remove worker-loader (go-gitea#23548)
  [skip ci] Updated translations via Crowdin
  Return `repository` in npm package metadata endpoint (go-gitea#23539)
  Fix diff detail buttons wrapping, use tippy for review box (go-gitea#23271)
  Do not store user projects as organization projects (go-gitea#23353)
  Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (go-gitea#23513)
  Increase horizontal page padding (go-gitea#23507)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@yardenshoham yardenshoham yardenshoham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @silverwind @codecov-commenter @delvh @yardenshoham @GiteaBot