Remove id="comment-form" dead code, fix tag
#23555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
approved these changes
Mar 18, 2023
delvh
approved these changes
Mar 18, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23555 +/- ##
==========================================
- Coverage 47.14% 47.12% -0.02%
==========================================
Files 1149 1154 +5
Lines 151446 152327 +881
==========================================
+ Hits 71397 71782 +385
- Misses 71611 72068 +457
- Partials 8438 8477 +39
... and 37 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I think it's not necessary to backport this since it's a refactor. |
|
🎺 🤖 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 22, 2023
* upstream/main: Use a general approch to improve a11y for all checkboxes and dropdowns. (go-gitea#23542) [skip ci] Updated translations via Crowdin Update PR documentation (go-gitea#23620) Set opaque background on markup and images (go-gitea#23578) Decouple the issue-template code from comment_tab.tmpl (go-gitea#23556) Remove `id="comment-form"` dead code, fix tag (go-gitea#23555) Introduce path Clean/Join helper functions (go-gitea#23495) Remove conflicting CSS rules on notifications, improve notifications table (go-gitea#23565) Remove @metalmatze as maintainer (go-gitea#23612) Keep (add if not existing) xmlns attribute for generated SVG images (go-gitea#23410)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been dead code since #5073 .
#5073duplicated the code in a newifblock.The dead code blocks