Change Close to either Close issue or Close pull request
#23506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23506 +/- ##
==========================================
+ Coverage 47.14% 47.16% +0.01%
==========================================
Files 1149 1154 +5
Lines 151446 152195 +749
==========================================
+ Hits 71397 71778 +381
- Misses 71611 71950 +339
- Partials 8438 8467 +29
... and 17 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
delvh
reviewed
Mar 15, 2023
|
The Gitea convention seems to be title case for buttons like these, so |
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: delvh <dev.lh@web.de>
Done |
delvh
approved these changes
Mar 16, 2023
|
Backport v1.19? Do we still have time? |
wolfogre
approved these changes
Mar 16, 2023
1.19.1 :) |
|
I don't know why CI keeps failing on codecov |
|
I was unable to create a backport for 1.19, please send one manually. 🍵 |
|
Ok no need to backport |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 17, 2023
* giteaofficial/main: Use `<nav>` instead of `<div>` in the global navbar (go-gitea#23125) Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (go-gitea#23450) [skip ci] Updated translations via Crowdin Make time tooltips interactive (go-gitea#23526) Update mini-css-extract-plugin, remove postcss (go-gitea#23520) Fix review comment context menu clipped bug (go-gitea#23523) Add absent repounits to create/edit repo API (go-gitea#23500) Fix tags sort by creation time (descending) on branch/tag dropdowns (go-gitea#23491) Allow both fullname and username search when `DEFAULT_SHOW_FULL_NAME` is true (go-gitea#23463) Handle files starting with colons in WalkGitLog (go-gitea#22935) Change `Close` to either `Close issue` or `Close pull request` (go-gitea#23506) Update act (go-gitea#23512) Move pidfile creation from setting to web cmd package (go-gitea#23285)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discord discussion, the close button in the issue comment box is more descriptive.
Before
For both issue and pull request
After
Issue
Pull request