Skip to content

Display the version of runner in the runner list #23490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 20, 2023
Merged

Display the version of runner in the runner list #23490

merged 9 commits into from
Mar 20, 2023

Conversation

sillyguodong
Copy link
Contributor

Close: #23489

Change

  1. Add version column to action_runner table.
  2. Read the runner version from the request header, and update it in DB.
  3. Display version in runner list

Screenshot

image

@lunny lunny added the type/enhancement An improvement of existing functionality label Mar 15, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 15, 2023
wolfogre
wolfogre reviewed Mar 16, 2023
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2023
@delvh
Copy link
Member

delvh commented Mar 18, 2023

Please fix the conflicts so that this PR can be merged.

@sillyguodong
Merge branch 'main' into feature/issue_23489
810dfdd 
# Conflicts:
#	models/migrations/migrations.go
#	models/migrations/v1_20/v247.go
@sillyguodong
Copy link
Contributor Author

Please fix the conflicts so that this PR can be merged.

done

@techknowlogick techknowlogick enabled auto-merge (squash) March 20, 2023 01:57
@techknowlogick techknowlogick merged commit 371520d into go-gitea:main Mar 20, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 20, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
34dcc5c 
* giteaofficial/main: (23 commits)
  Display the version of runner in the runner list (go-gitea#23490)
  Add `.patch` to `attachment.ALLOWED_TYPES` (go-gitea#23580)
  Sort Python package descriptors by version to mimic PyPI format (go-gitea#23550)
  Use `project.IconName` instead of repeated unreadable `if-else` chains (go-gitea#23538)
  Match api migration behavior to web behavior (go-gitea#23552)
  Fix dropdown icon misalignment when using fomantic icon (go-gitea#23558)
  Enable color for consistency checks diffs (go-gitea#23563)
  [skip ci] Updated translations via Crowdin
  Fix sticky header in diff view (go-gitea#23554)
  Fix some broken css (go-gitea#23560)
  Fix JS error on compare page (go-gitea#23551)
  Upgrade to npm lockfile v3 and explicitely set it (go-gitea#23561)
  Fix long name ui issues and label ui issue  (go-gitea#23541)
  Remove worker-loader (go-gitea#23548)
  [skip ci] Updated translations via Crowdin
  Return `repository` in npm package metadata endpoint (go-gitea#23539)
  Fix diff detail buttons wrapping, use tippy for review box (go-gitea#23271)
  Do not store user projects as organization projects (go-gitea#23353)
  Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (go-gitea#23513)
  Increase horizontal page padding (go-gitea#23507)
  ...
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 20, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@sillyguodong sillyguodong deleted the feature/issue_23489 branch February 29, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Display the version of runner in runner list page.
6 participants
@sillyguodong @delvh @lunny @wolfogre @techknowlogick @GiteaBot