Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 25, 2022

No description provided.

@delvh
Copy link
Member

delvh commented Dec 29, 2022

Should we perhaps make this PR breaking by also renaming the config options
([repository].{DEFAULT,DISABLED}_REPO_UNITS, (description in [ui].ISSUE_PAGING_NUM),[project].*)
?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2022
@lunny
Copy link
Member Author

lunny commented Dec 29, 2022

Should we perhaps make this PR breaking by also renaming the config options ([repository].{DEFAULT,DISABLED}_REPO_UNITS, (description in [ui].ISSUE_PAGING_NUM),[project].*) ?

Maybe add depreciated in all [project] section configurations and start a new section named [board]?
[ui].ISSUE_PAGING_NUM should be moved to database based system configuration.

@delvh
Copy link
Member

delvh commented Dec 29, 2022

[ui].ISSUE_PAGING_NUM: for that I simply meant the description, as it's probably best to purge project completely from the words used in this repo to prevent confusion.

Maybe add depreciated in all [project] section configurations and start a new section named [board]?

That was also my intention.
We can also deprecate the now invalid values inside {DISABLED,DEFAULT}_REPO_UNIT, so that this PR does not break anything for now, only to warn that it will be removed in a later version.

@lunny
Copy link
Member Author

lunny commented Mar 25, 2023

Closed as too many conflicts.

@lunny lunny closed this Mar 25, 2023
@lunny lunny deleted the lunny/rename_projects branch March 25, 2023 07:44
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants