Skip to content

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 7, 2022

golangci-lint deprecated a bunch of linters, removed them.

@silverwind silverwind marked this pull request as draft December 7, 2022 19:53
@silverwind silverwind added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 7, 2022
@silverwind silverwind marked this pull request as ready for review December 7, 2022 20:06
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 7, 2022
@silverwind silverwind added this to the 1.19.0 milestone Dec 7, 2022
@lunny
Copy link
Member

lunny commented Dec 8, 2022

  • air is updated to the commit that added include_file which allows watching main.go

  • golangci-lint deprecated a bunch of linters, removed them.

Air is not a released version?

@silverwind
Copy link
Member Author

No because auther hasn't released in a while, but I guess I will revert, it's a minor issue.

@silverwind
Copy link
Member Author

Reverted air and squashed.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 8, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2022
@lunny lunny merged commit 0585ac3 into go-gitea:main Dec 8, 2022
@silverwind silverwind deleted the godeps branch December 8, 2022 10:36
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2022
* giteaofficial/main:
  Use multi reader instead to concat strings (go-gitea#22099)
  Fix sorting admin user list by last login (go-gitea#22081)
  Fix wrong default value for update checker on app.example.ini (go-gitea#22084)
  fix(config): remove context on config template (go-gitea#22096)
  [skip ci] Updated licenses and gitignores
  Update xorm (go-gitea#22094)
  Remove unnecessary whitespace in snapcraft.yaml (go-gitea#22090)
  Rename almost all Ctx functions (go-gitea#22071)
  Change ID pattern of raw content container for issue (go-gitea#21966)
  Optimize html templates (go-gitea#22080)
  Add API management for issue/pull and comment attachments (go-gitea#21783)
  Rename actions to operations on UI (go-gitea#22067)
  Update go dev dependencies (go-gitea#22064)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants