Skip to content

Remove all package data after tests #22984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 23, 2023
Merged

Remove all package data after tests #22984

merged 7 commits into from
Feb 23, 2023

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Feb 19, 2023

Fixes #21020

@KN4CK3R KN4CK3R added this to the 1.20.0 milestone Feb 19, 2023
zeripath
zeripath reviewed Feb 19, 2023
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2023
zeripath
zeripath reviewed Feb 19, 2023
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2023
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Feb 19, 2023

I would like to wait for https://gitea.com/xorm/xorm/pulls/2220 because this could shrink this PR a little bit.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 19, 2023
@delvh
Copy link
Member

delvh commented Feb 20, 2023 •
edited
Loading

The xorm PR was merged, so this PR should be updated.
(Feel free to re-add the label once it is updated)

@delvh delvh removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 20, 2023
techknowlogick
techknowlogick previously requested changes Feb 21, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for xorm dep update

@lunny lunny dismissed techknowlogick’s stale review February 23, 2023 10:10

xorm dep updated

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 23, 2023
@lunny lunny merged commit 0ae1ed7 into go-gitea:main Feb 23, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 23, 2023
@KN4CK3R KN4CK3R deleted the cleanup-package-tests branch February 23, 2023 14:12
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
514311a 
* giteaofficial/main:
  Make issue meta dropdown support Enter, confirm before reloading (go-gitea#23014)
  Fix SyncOnCommit always return false in API of push_mirrors (go-gitea#23088)
  Fix commit name in Apply Patch page (go-gitea#23086)
  Add wrapper to author to avoid long name ui problem (go-gitea#23030)
  Avoid Hugo from adding quote to actions url (go-gitea#23097)
  Remove all package data after tests (go-gitea#22984)
  Change style to improve whitespaces trimming inside inline markdown code  (go-gitea#23093)
  Nest metadata in refactoring docs (go-gitea#23087)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick techknowlogick left review comments

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/testing
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Package tests (as run by make test-sqlite) do not clean up after themselves
6 participants
@KN4CK3R @delvh @techknowlogick @zeripath @lunny @GiteaBot