Fix calls to i18n in templates #21394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
approved these changes
Oct 10, 2022
silverwind
approved these changes
Oct 10, 2022
6543
approved these changes
Oct 10, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 11, 2022
* upstream/main: Add user/organization code search (go-gitea#19977) Stop logging CheckPath returns error: context canceled (go-gitea#21064) Hook go-licenses into tidy again (go-gitea#21353) Fix missing left and right carets in TRANSLATORS (go-gitea#21397) Fix calls to i18n in templates (go-gitea#21394) Update JS dependencies and eslint config (go-gitea#21388) Allow creation of OAuth2 applications for orgs (go-gitea#18084) Fix typos in PullRequestMergeForm.vue header comment (go-gitea#21378) Use weighted algorithm for string matching when finding files in repo (go-gitea#21370) Bump playwright to 1.26.1 (go-gitea#21357) npm package registry support for `bin` (go-gitea#21372) Removed one extra whitespace in footer after "Template" (go-gitea#21364)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the
.i18nhas been refactored to.locale, some PRs using.i18nwere still merged.This PR fixes the calls to
.i18n.At the moment,
{{.nosuch.nosuch "..."}}won't cause template error so these mistakes don't cause 500 and haven't been found.