Skip to content

Conversation

wxiaoguang
Copy link
Contributor

Follows #21129 (comment)

A lot of users are asking similar questions.

The old content in FAQ doesn't seem to be related to the problem.

@6543
Copy link
Member

6543 commented Sep 29, 2022

if you mention webhooks, a common mistake is to not enable webhooks to local networks and have some service runing local that should be connected ...

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 29, 2022
@6543 6543 added type/docs This PR mainly updates/creates documentation and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 29, 2022
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Sep 29, 2022

if you mention webhooks, a common mistake is to not enable webhooks to local networks and have some service runing local that should be connected ...

I have thought about it, but many people don't understand the difference (see the issue title: "push webhook doesn't fire ")

For the webhook part, the localnetwork problem already has a clear error message, users should be able to understand it correctly.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 29, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 29, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 29, 2022
@6543
Copy link
Member

6543 commented Sep 29, 2022

.

@6543 6543 merged commit 3b6a7e5 into go-gitea:main Sep 29, 2022
@wxiaoguang wxiaoguang deleted the fix-faq-push branch September 30, 2022 03:07
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 30, 2022
* upstream/main:
  Add pages to view watched repos and subscribed issues/PRs (go-gitea#17156)
  Fix the hook related FAQ contents (go-gitea#21297)
  Check if email is used when updating user (go-gitea#21289)
  Add name field for org api (go-gitea#21270)
  Add API endpoint to get changed files of a PR (go-gitea#21177)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants