Improve org error handling #2117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fc5644 to
8a97c00
Compare
Return new error type Use good error check Use new method to check error Update tests
8a97c00 to
0d24812
Compare
|
This is ok for review |
|
LGTM |
lafriks
requested changes
Jul 6, 2017
routers/api/v1/api.go
Outdated
| if err != nil { | ||
| if models.IsErrUserNotExist(err) { | ||
| if models.IsErrOrgNotExist(err) { | ||
| ctx.Status(404) | ||
| } else { | ||
| ctx.Error(500, "GetUserByName", err) |
lafriks
approved these changes
Jul 6, 2017
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And enforcement that :orgname is a org by using GetOrgByName inplace of GetUserByName and specific error check (GetOrgByName return ErrOrgNotExist not IsErrUserNotExist ) like it was done in CreateOrgRepo.
Before this PR we could use username as orgname.
This could also be done for enforcement of team in a other PR.