Skip to content

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Sep 5, 2022

This removes the JS dependency in the checks pipeline. JSON output is different because the previous JS did indent the license data differently and a JSON key was changed, but the end result is the same as it gets re-indented by wepack.

@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 5, 2022
@silverwind silverwind added this to the 1.18.0 milestone Sep 5, 2022
@silverwind
Copy link
Member Author

silverwind commented Sep 5, 2022

There were a few cases of duplicate licenses like:

github.com/prometheus/common/LICENSE
github.com/prometheus/common/NOTICE

I removed the NOTICE file because of it. Ideally we should use a priority list for those files but I think that can be done later.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2022
@delvh
Copy link
Member

delvh commented Sep 6, 2022

Closes #21096

@techknowlogick techknowlogick merged commit 52c2ef7 into go-gitea:main Sep 7, 2022
@silverwind silverwind deleted the licgo branch September 7, 2022 21:37
@silverwind
Copy link
Member Author

silverwind commented Sep 7, 2022

I think main branch is broken because of the targets introduced in 8080e23 which trigger a go step inside a node container. No idea why this didn't show up earlier.

@silverwind
Copy link
Member Author

#21108 should fix it.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 9, 2022
* upstream/main:
  Make the vscode clone link respect transport protocol (go-gitea#20557)
  Fix typo of issue template name (go-gitea#21117)
  [skip ci] Updated translations via Crowdin
  Fix pagination limit parameter problem (go-gitea#21109)
  Rewrite go license generator in go (go-gitea#21078)
  Allow uppercase ASCII alphabet in PyPI package names (go-gitea#21095)
  Fix various typos (go-gitea#21103)
  Update docs issue-pull-request-templates.zh-cn.md (go-gitea#21030)
  Upgrade the document about how to collect logs for systemd and docker (go-gitea#21101)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants