Fix markdown anchor re-clicking #21931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hashchange event did not fire on re-click of a active anchor. Instead, use the click event. Fixes: go-gitea#21680
zeripath
approved these changes
Nov 24, 2022
delvh
reviewed
Nov 24, 2022
delvh
approved these changes
Nov 25, 2022
|
I pushed a fix so that it only aborts when |
delvh
approved these changes
Nov 25, 2022
|
make L-G-T-M work |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Nov 26, 2022
The hashchange event did not fire on re-click of a active anchor. Instead, use the click event which always fires. Fixes: go-gitea#21680 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net>
lunny
added a commit
that referenced
this pull request
Nov 26, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 29, 2022
* giteaofficial/main: Use random bytes to generate access token (go-gitea#21959) Replace fmt.Sprintf with hex.EncodeToString (go-gitea#21960) Implement FSFE REUSE for golang files (go-gitea#21840) Correct the fallbacks for mailer configuration (go-gitea#21945) [skip ci] Updated licenses and gitignores Fix typos (go-gitea#21947) Fix markdown anchor re-clicking (go-gitea#21931) Prevent NPE if trying to restore an already restored deleted branch (go-gitea#21940) add rel="me" to org.website link (go-gitea#21941)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hashchange event did not fire on re-click of a active anchor. Instead, use the click event which always fires.
Fixes: #21680