Skip to content

Conversation

Mai-Lapyst
Copy link
Contributor

@Mai-Lapyst Mai-Lapyst commented Jul 15, 2022

automatically set repository link for package based on the repository url present inside package.json

closes #20146

@wxiaoguang wxiaoguang changed the title npm packages: automatically set repository link for package based on … npm packages: set repository link based on the url in package.json Jul 15, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 15, 2022
@Gusted Gusted added this to the 1.18.0 milestone Jul 21, 2022
@Gusted Gusted added the type/enhancement An improvement of existing functionality label Jul 21, 2022
@Mai-Lapyst
Copy link
Contributor Author

@Gusted @KN4CK3R Any more changes needed to get this PR merged?

@Mai-Lapyst Mai-Lapyst requested review from KN4CK3R and Gusted and removed request for KN4CK3R September 5, 2022 10:22
@silverwind
Copy link
Member

silverwind commented Sep 5, 2022

I think people were just waiting for the comments to resolve. Are they?

@Mai-Lapyst
Copy link
Contributor Author

They are resolved from my understanding; just wanted to give the commentors some time to look through it and mark it themselves. My bad. Have marked all as resolved.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2022
@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 26, 2022
@lunny lunny modified the milestones: 1.19.0, 1.20.0 Feb 3, 2023
@Mai-Lapyst Mai-Lapyst force-pushed the npm-automatic-repositoryLink branch from 8f17b52 to bf25dc2 Compare March 28, 2023 09:43
@Mai-Lapyst
Copy link
Contributor Author

Rebased onto main

@Mai-Lapyst Mai-Lapyst requested review from lunny and Gusted and removed request for Gusted and lunny March 28, 2023 09:44
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2023
@jolheiser jolheiser enabled auto-merge (squash) March 28, 2023 17:29
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit 5cd1d6c into go-gitea:main Mar 28, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 28, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 29, 2023
* upstream/main:
  Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (go-gitea#23687)
  Add CSS rules for basic colored labels (go-gitea#23774)
  Add meilisearch support (go-gitea#23136)
  Add missing translation for `actions.runners.reset_registration_token_success` (go-gitea#23732)
  [skip ci] Updated translations via Crowdin
  Implement Issue Config (go-gitea#20956)
  Set repository link based on the url in package.json for npm packages (go-gitea#20379)
  Add API to manage issue dependencies (go-gitea#17935)
  Add creation time in tag list page (go-gitea#23693)
  Make minio package support legacy MD5 checksum (go-gitea#23768)
  Yarden Shoham has a new email address (go-gitea#23767)
  fix br display for packages curls (go-gitea#23737)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@Mai-Lapyst Mai-Lapyst deleted the npm-automatic-repositoryLink branch February 10, 2024 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm packages: respect "repository" field to automatically set repository link of uploaded packages
7 participants