Skip to content

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jul 4, 2022

  • Given we use go1.18 for this and don't rely on the Go 1.11 modules behavior(we use the modern go run & go get which has the correct behavior by-default).

- Given we use go1.18 for this and don't rely on the Go 1.11 modules
behavior(we use the modern `go run` & `go get` which has the correct
behavior by-default).
@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 4, 2022
@Gusted Gusted added this to the 1.18.0 milestone Jul 4, 2022
@Gusted Gusted added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 4, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 4, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 4, 2022
@lunny lunny merged commit f9b172d into go-gitea:main Jul 4, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 4, 2022
* upstream/main:
  Remove `GO111MODULE` (go-gitea#20221)
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this pull request Jul 9, 2022
- Given we use go1.18 for this and don't rely on the Go 1.11 modules
behavior(we use the modern `go run` & `go get` which has the correct
behavior by-default).
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
- Given we use go1.18 for this and don't rely on the Go 1.11 modules
behavior(we use the modern `go run` & `go get` which has the correct
behavior by-default).
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants