Skip to content

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jun 26, 2022

  • Firefox on Windows will unconditionally show scrollbars when you specify overflow: scroll. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary.
  • Resolves Unnecessary horizontal scrollbar arrows on Firefox #20139

- Firefox on Windows will unconditionally show scrollbars when you
specify `overflow: scroll`. This is bad behavior, as you don't always
need the scrollbar. Changing the scroll value to auto fixes this issue
and only shows the scrollbar when necessary.
- Resolves go-gitea#20139
@Gusted Gusted added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.17 labels Jun 26, 2022
@Gusted Gusted added this to the 1.18.0 milestone Jun 26, 2022
Gusted pushed a commit to Gusted/gitea that referenced this pull request Jun 26, 2022
- Backport go-gitea#20142
  - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary.
  - Resolves go-gitea#20139
@Gusted Gusted added the backport/done All backports for this PR have been created label Jun 26, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2022
lunny pushed a commit that referenced this pull request Jun 27, 2022
- Backport #20142
  - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary.
  - Resolves #20139
@lunny
Copy link
Member

lunny commented Jun 27, 2022

LGTM

@lunny lunny merged commit 5371964 into go-gitea:main Jun 27, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 28, 2022
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Add username check to doctor (go-gitea#20140)
  Refactor `i18n` to `locale` (go-gitea#20153)
  Remove support for sr-SP (go-gitea#20155)
  Hide notify mail setting ui if not enabled (go-gitea#20138)
  Fix custom folder name in customization docs (go-gitea#20148)
  Add missing parameter for error in log message (go-gitea#20144)
  Show scrollbar when necessary (go-gitea#20142)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
wxiaoguang pushed a commit that referenced this pull request Jul 10, 2022
Addition to: Show scrollbar when necessary #20142
Fixes the "empty" scrollbars with Firefox.
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Jul 10, 2022
Addition to: Show scrollbar when necessary go-gitea#20142
Fixes the "empty" scrollbars with Firefox.
zeripath pushed a commit that referenced this pull request Jul 10, 2022
Addition to: Show scrollbar when necessary #20142
Fixes the "empty" scrollbars with Firefox.
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
- Firefox on Windows will unconditionally show scrollbars when you
specify `overflow: scroll`. This is bad behavior, as you don't always
need the scrollbar. Changing the scroll value to auto fixes this issue
and only shows the scrollbar when necessary.
- Resolves go-gitea#20139

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Addition to: Show scrollbar when necessary go-gitea#20142
Fixes the "empty" scrollbars with Firefox.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary horizontal scrollbar arrows on Firefox
5 participants