Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 25, 2022

No description provided.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Jun 25, 2022
@Gusted Gusted added this to the 1.18.0 milestone Jun 25, 2022
@lunny lunny requested review from KN4CK3R, zeripath and a1012112796 and removed request for KN4CK3R and zeripath June 26, 2022 13:03
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 26, 2022
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #20133 (aef67da) into main (711cbcc) will decrease coverage by 0.00%.
The diff coverage is 53.93%.

@@            Coverage Diff             @@
##             main   #20133      +/-   ##
==========================================
- Coverage   46.91%   46.91%   -0.01%     
==========================================
  Files         973      973              
  Lines      134721   134838     +117     
==========================================
+ Hits        63204    63256      +52     
- Misses      63768    63825      +57     
- Partials     7749     7757       +8     
Impacted Files Coverage Δ
models/issues/issue_project.go 30.00% <0.00%> (-2.24%) ⬇️
modules/markup/markdown/toc.go 0.00% <0.00%> (ø)
modules/setting/i18n.go 100.00% <ø> (ø)
modules/setting/setting.go 47.59% <ø> (+0.38%) ⬆️
modules/templates/helper.go 45.86% <ø> (ø)
routers/install/install.go 1.77% <0.00%> (ø)
routers/install/routes.go 44.00% <0.00%> (ø)
routers/private/hook_pre_receive.go 41.88% <0.00%> (ø)
routers/web/admin/admin.go 10.02% <0.00%> (ø)
routers/web/auth/auth.go 26.26% <0.00%> (-0.13%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ec628...aef67da. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Jun 30, 2022

make L-G-T-M work

@lunny lunny merged commit 184a7d4 into go-gitea:main Jun 30, 2022
@lunny lunny deleted the lunny/fix_assign_project branch June 30, 2022 15:55
lunny added a commit to lunny/gitea that referenced this pull request Jun 30, 2022
…oject to issue (go-gitea#20133)

* Check if project has the same repository id with issue when assign project to issue

* Check if issue's repository id match project's repository id

* Add more permission checking

* Remove invalid argument

* Fix errors

* Add generic check

* Remove duplicated check

* Return error + add check for new issues

* Apply suggestions from code review

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 1, 2022
* upstream/main:
  Fix cli command restore-repo: "units" should be splitted to string slice, to match the old behavior and match the dump-repo's behavior (go-gitea#20183)
  [skip ci] Updated translations via Crowdin
  Fix `dump-repo` git init, fix wrong error type for NullDownloader (go-gitea#20182)
  Check if project has the same repository id with issue when assign project to issue (go-gitea#20133)
  [skip ci] Updated translations via Crowdin
6543 added a commit that referenced this pull request Jul 1, 2022
…oject to issue (#20133) (#20188)

* Check if project has the same repository id with issue when assign project to issue

* Check if issue's repository id match project's repository id

* Add more permission checking

* Remove invalid argument

* Fix errors

* Add generic check

* Remove duplicated check

* Return error + add check for new issues

* Apply suggestions from code review

Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
Gusted pushed a commit to Gusted/gitea that referenced this pull request Jul 1, 2022
…0133)

- Backport go-gitea#20133
  - Check correctly for permission when we fetch a new issue(via ID)
is controlled by the user.
@Gusted Gusted added the backport/done All backports for this PR have been created label Jul 1, 2022
6543 added a commit that referenced this pull request Jul 1, 2022
…20196)

* Check if project has the same repository id with issue when assign project to issue

* Check if issue's repository id match project's repository id

* Add more permission checking

* Remove invalid argument

* Fix errors

* Add generic check

* Remove duplicated check

* Return error + add check for new issues

* Apply suggestions from code review

Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
tyroneyeh added a commit to tyroneyeh/gitea that referenced this pull request Jul 13, 2022
commit 713bc6c
Author: 6543 <6543@obermui.de>
Date:   Tue Jul 12 20:26:27 2022 +0200

    Changelog for 1.16.9 (update) (go-gitea#20341)

    * Changelog for 1.16.9 (update)

    * update security section

commit 6b7e860
Author: Lunny Xiao <xiaolunwen@gmail.com>
Date:   Wed Jul 13 01:13:31 2022 +0800

    Hide notify mail setting ui if not enabled (go-gitea#20138) (go-gitea#20337)

    Backport go-gitea#20138

commit 0f89417
Author: Gusted <williamzijl7@hotmail.com>
Date:   Tue Jul 12 12:52:20 2022 +0000

    Add write check for creating Commit status (go-gitea#20332) (go-gitea#20334)

    - Backport go-gitea#20332
      - Add write code checks for creating new commit status
      - Regression from go-gitea#5314
      - Resolves go-gitea#20331

commit 7c80a0b
Author: zeripath <art27@cantab.net>
Date:   Mon Jul 11 10:15:43 2022 +0100

    Ensure that drone tags 1.16.x and 1.16 on push to v1.16.x tag (go-gitea#20304)

    We need pushes to v1.16.9 to create tags to 1.16.9 and 1.16 but not 1 or latest.

    We have previously adjusted the manifest to remove the latest tag, and have removed
    auto_tags so that 1 does not get tagged but in doing so we also stopped 1.16 being
    tagged. So here we just state the that we tag x.yy in addition to x.yyz*.

    Signed-off-by: Andrew Thornton <art27@cantab.net>

commit b42df31
Author: zeripath <art27@cantab.net>
Date:   Wed Jul 6 02:47:16 2022 +0100

    Only show Followers that current user can access (go-gitea#20220) (go-gitea#20253)

    Backport go-gitea#20220

    Users who are following or being followed by a user should only be
    displayed if the viewing user can see them.

    Signed-off-by: Andrew Thornton <art27@cantab.net>

commit 6162fb0
Author: Gusted <williamzijl7@hotmail.com>
Date:   Fri Jul 1 17:39:10 2022 +0200

    Check for permission when fetching user controlled issues (go-gitea#20133) (go-gitea#20196)

    * Check if project has the same repository id with issue when assign project to issue

    * Check if issue's repository id match project's repository id

    * Add more permission checking

    * Remove invalid argument

    * Fix errors

    * Add generic check

    * Remove duplicated check

    * Return error + add check for new issues

    * Apply suggestions from code review

    Co-authored-by: Gusted <williamzijl7@hotmail.com>
    Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
    Co-authored-by: 6543 <6543@obermui.de>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
…oject to issue (go-gitea#20133)

* Check if project has the same repository id with issue when assign project to issue

* Check if issue's repository id match project's repository id

* Add more permission checking

* Remove invalid argument

* Fix errors

* Add generic check

* Remove duplicated check

* Return error + add check for new issues

* Apply suggestions from code review

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants