Skip to content

Fix delete pull head ref for DeleteIssue #20032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2022
Merged

Fix delete pull head ref for DeleteIssue #20032

merged 3 commits into from
Jun 19, 2022

Conversation

a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Jun 19, 2022 •
edited by zeripath
Loading

In DeleteIssue the PR git head reference should be /refs/pull/xxx/head not /refs/pull/xxx

Fix #19655

@a1012112796
fix delete pull head ref for DeleteIssue
eb77538 
fix go-gitea#19655

Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796 a1012112796 added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 19, 2022
@a1012112796
add different help message for delete pull request
eda99e7 
Signed-off-by: a1012112796 <1012112796@qq.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@e86f18a). Click here to learn what that means.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #20032   +/-   ##
=======================================
  Coverage        ?   46.97%           
=======================================
  Files           ?      972           
  Lines           ?   134536           
  Branches        ?        0           
=======================================
  Hits            ?    63197           
  Misses          ?    63595           
  Partials        ?     7744
Impacted Files Coverage Δ
routers/web/repo/issue.go 36.71% <0.00%> (ø)
services/issue/issue.go 31.84% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86f18a...ca3f388. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 19, 2022
@lunny
Copy link
Member

lunny commented Jun 19, 2022

Could you explain the bug and how this PR resolve it?

@a1012112796
Copy link
Member Author

a1012112796 commented Jun 19, 2022 •
edited
Loading

Could you explain the bug and how this PR resolve it?

just a nit. the format of pull head ref is refs/pull/{index}/head, not refs/pull/{index}.
image

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2022
@lunny lunny merged commit cc42c64 into go-gitea:main Jun 19, 2022
@lunny
Copy link
Member

lunny commented Jun 19, 2022

Please send backport to v1.17

@a1012112796 a1012112796 deleted the fix-del-pull branch June 19, 2022 10:48
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jun 19, 2022
@a1012112796 @6543
fix delete pull head ref for DeleteIssue (go-gitea#20032)
b44645c 
* fix delete pull head ref for DeleteIssue

fix go-gitea#19655

Signed-off-by: a1012112796 <1012112796@qq.com>

* add different help message for delete pull request

Signed-off-by: a1012112796 <1012112796@qq.com>

Co-authored-by: 6543 <6543@obermui.de>
@a1012112796 a1012112796 mentioned this pull request Jun 19, 2022
Merged
@a1012112796 a1012112796 added the backport/done All backports for this PR have been created label Jun 19, 2022
@zeripath zeripath changed the title fix delete pull head ref for DeleteIssue Fix delete pull head ref for DeleteIssue Jun 19, 2022
@zeripath
Copy link
Contributor

Honestly could we please try to write better PR opening comments. Explain what the PR is doing and why.

zeripath pushed a commit that referenced this pull request Jun 19, 2022
@a1012112796
Fix delete pull head ref for DeleteIssue (#20032) (#20034)
a4b1967 
Backport #20032 

In DeleteIssue the PR git head reference should be `/refs/pull/xxx/head` not `/refs/pull/xxx`

Fix #19655

Signed-off-by: a1012112796 <1012112796@qq.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 20, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/release/v1.17'
d03cd54 
* giteaofficial/release/v1.17: (35 commits)
  Simplify and fix migration 216 (go-gitea#20036)
  Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038) (go-gitea#20041)
  Backtick table name in generic orphan check (go-gitea#20019) (go-gitea#20037)
  Respond with a 401 on git push when password isn't changed yet (go-gitea#20027)
  Fix delete pull head ref for DeleteIssue (go-gitea#20032)  (go-gitea#20034)
  use quoted regexp instead of git fixed-value (go-gitea#20030)
  Dump should only copy regular files and symlink regular files (go-gitea#20015) (go-gitea#20021)
  Return 404 when tag is broken (go-gitea#20024)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Add fgprof pprof profiler (go-gitea#20005)
  [skip ci] Updated translations via Crowdin
  Improve action table indices (go-gitea#19472)
  Add dbconsistency checks for Stopwatches (go-gitea#20010)
  fix push mirrors URL are no longer displayed on the UI (go-gitea#20011)
  Empty log queue on flush and close (go-gitea#19994)
  [skip ci] Updated translations via Crowdin
  Stop spurious APIFormat stopwatches logs (go-gitea#20008)
  Fix CountOrphanedLabels in orphan check (go-gitea#20009)
  Write Commit-Graphs in RepositoryDumper (go-gitea#20004)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
201d49d 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Catch the error before the response is processed by goth. (go-gitea#20000)
  Adjust transaction handling via db.Context (go-gitea#20031)
  Add more linters to improve code readability (go-gitea#19989)
  [skip ci] Updated translations via Crowdin
  Disable federation by default (go-gitea#20045)
  Respond with a 401 on git push when password isn't changed yet (go-gitea#20026)
  Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038)
  Simplify and fix migration 216 (go-gitea#20035)
  use quoted regexp instead of git fixed-value (go-gitea#20029)
  fix delete pull head ref for DeleteIssue (go-gitea#20032)
  User keypairs and HTTP signatures for ActivityPub federation using go-ap (go-gitea#19133)
  Backtick table name in generic orphan check (go-gitea#20019)
  Update document to clarify that ALLOWED_DOMAINS/BLOCKED_DOMAINS support wildcard (go-gitea#20016)
  Return 404 when tag is broken (go-gitea#20017)
  Dump should only copy regular files and symlink regular files (go-gitea#20015)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@a1012112796 @6543
fix delete pull head ref for DeleteIssue (go-gitea#20032)
8b870c2 
* fix delete pull head ref for DeleteIssue

fix go-gitea#19655

Signed-off-by: a1012112796 <1012112796@qq.com>

* add different help message for delete pull request

Signed-off-by: a1012112796 <1012112796@qq.com>

Co-authored-by: 6543 <6543@obermui.de>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@a1012112796 @6543 @AbdulrhmnGhanem
fix delete pull head ref for DeleteIssue (go-gitea#20032)
63f7a8a 
* fix delete pull head ref for DeleteIssue

fix go-gitea#19655

Signed-off-by: a1012112796 <1012112796@qq.com>

* add different help message for delete pull request

Signed-off-by: a1012112796 <1012112796@qq.com>

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete a merged pull request return 500
7 participants
@a1012112796 @codecov-commenter @lunny @zeripath @delvh @GiteaBot @6543