Skip to content

Dump should only copy regular files and symlink regular files #20015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2022
Merged

Dump should only copy regular files and symlink regular files #20015

merged 2 commits into from
Jun 18, 2022

Conversation

wxiaoguang
Copy link
Contributor

As the title.

Close #20014

@wxiaoguang wxiaoguang mentioned this pull request Jun 18, 2022
Closed
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Jun 18, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 18, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #20015 (6551609) into main (8eefe2a) will decrease coverage by 0.11%.
The diff coverage is 25.80%.

@@            Coverage Diff             @@
##             main   #20015      +/-   ##
==========================================
- Coverage   46.95%   46.84%   -0.12%     
==========================================
  Files         968      968              
  Lines      134128   134267     +139     
==========================================
- Hits        62979    62896      -83     
- Misses      63444    63664     +220     
- Partials     7705     7707       +2
Impacted Files Coverage Δ
cmd/dump.go 0.67% <0.00%> (-0.04%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
modules/doctor/dbconsistency.go 4.32% <0.00%> (-0.15%) ⬇️
modules/templates/helper.go 46.14% <ø> (+1.80%) ⬆️
models/action.go 48.26% <100.00%> (+1.22%) ⬆️
models/webhook/webhook.go 52.68% <0.00%> (-16.13%) ⬇️
build/codeformat/formatimports.go 59.85% <0.00%> (-15.15%) ⬇️
routers/web/admin/users.go 27.79% <0.00%> (-10.39%) ⬇️
routers/web/admin/admin.go 0.00% <0.00%> (-10.03%) ⬇️
models/git/protected_tag.go 60.29% <0.00%> (-7.36%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870d7f9...6551609. Read the comment docs.

@wxiaoguang wxiaoguang merged commit 433443f into go-gitea:main Jun 18, 2022
@wxiaoguang wxiaoguang deleted the fix-dump-file-mode branch June 18, 2022 14:06
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jun 18, 2022
@wxiaoguang @6543
Dump should only copy regular files and symlink regular files (go-git…
19ef992 
…ea#20015)
@6543 6543 mentioned this pull request Jun 18, 2022
Merged
@6543 6543 modified the milestones: 1.17.0, 1.18.0 Jun 18, 2022
@6543 6543 added backport/v1.17 backport/done All backports for this PR have been created labels Jun 18, 2022
@6543
Copy link
Member

6543 commented Jun 18, 2022

-> #20021

lunny pushed a commit that referenced this pull request Jun 19, 2022
@6543 @wxiaoguang
Dump should only copy regular files and symlink regular files (#20015) (
a180d94 
#20021)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 20, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/release/v1.17'
d03cd54 
* giteaofficial/release/v1.17: (35 commits)
  Simplify and fix migration 216 (go-gitea#20036)
  Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038) (go-gitea#20041)
  Backtick table name in generic orphan check (go-gitea#20019) (go-gitea#20037)
  Respond with a 401 on git push when password isn't changed yet (go-gitea#20027)
  Fix delete pull head ref for DeleteIssue (go-gitea#20032)  (go-gitea#20034)
  use quoted regexp instead of git fixed-value (go-gitea#20030)
  Dump should only copy regular files and symlink regular files (go-gitea#20015) (go-gitea#20021)
  Return 404 when tag is broken (go-gitea#20024)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Add fgprof pprof profiler (go-gitea#20005)
  [skip ci] Updated translations via Crowdin
  Improve action table indices (go-gitea#19472)
  Add dbconsistency checks for Stopwatches (go-gitea#20010)
  fix push mirrors URL are no longer displayed on the UI (go-gitea#20011)
  Empty log queue on flush and close (go-gitea#19994)
  [skip ci] Updated translations via Crowdin
  Stop spurious APIFormat stopwatches logs (go-gitea#20008)
  Fix CountOrphanedLabels in orphan check (go-gitea#20009)
  Write Commit-Graphs in RepositoryDumper (go-gitea#20004)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
201d49d 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Catch the error before the response is processed by goth. (go-gitea#20000)
  Adjust transaction handling via db.Context (go-gitea#20031)
  Add more linters to improve code readability (go-gitea#19989)
  [skip ci] Updated translations via Crowdin
  Disable federation by default (go-gitea#20045)
  Respond with a 401 on git push when password isn't changed yet (go-gitea#20026)
  Alter hook_task TEXT fields to LONGTEXT (go-gitea#20038)
  Simplify and fix migration 216 (go-gitea#20035)
  use quoted regexp instead of git fixed-value (go-gitea#20029)
  fix delete pull head ref for DeleteIssue (go-gitea#20032)
  User keypairs and HTTP signatures for ActivityPub federation using go-ap (go-gitea#19133)
  Backtick table name in generic orphan check (go-gitea#20019)
  Update document to clarify that ALLOWED_DOMAINS/BLOCKED_DOMAINS support wildcard (go-gitea#20016)
  Return 404 when tag is broken (go-gitea#20017)
  Dump should only copy regular files and symlink regular files (go-gitea#20015)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@wxiaoguang
Dump should only copy regular files and symlink regular files (go-git…
cd55af0 
…ea#20015)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@wxiaoguang @AbdulrhmnGhanem
Dump should only copy regular files and symlink regular files (go-git…
9b8f2a7 
…ea#20015)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

gitea dump error (related to #19930)
6 participants
@wxiaoguang @codecov-commenter @6543 @lunny @delvh @GiteaBot