Skip to content

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Aug 18, 2022

This patch fixes the issue that the mirror address field is ignored from the repo setting form. This patch needs to be cherry-picked to 1.17.x maintain branch.

It'll be good if someone can help by adding an integration test for this issue :)

@lunny lunny added type/bug backport/v1.17 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 19, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 19, 2022
@Gusted Gusted added this to the 1.18.0 milestone Aug 20, 2022
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar behavior/checks how we do this in API for mirror management. As for integration testing you want to look at integrations/mirror_push-test.go

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 20, 2022
@zeripath zeripath merged commit 36dfe54 into go-gitea:main Aug 21, 2022
zeripath pushed a commit to zeripath/gitea that referenced this pull request Aug 21, 2022
Backport go-gitea#20850

This patch fixes the issue that the mirror address field is ignored from the repo setting form.
@BLumia BLumia deleted the fix-mirror-address branch August 22, 2022 00:56
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 22, 2022
* giteaofficial/main:
  update current stable version
  [skip ci] Updated translations via Crowdin
  Fix mirror address setting not working (go-gitea#20850)
  Support Proxy protocol (go-gitea#12527)
  Fix SQL Query for `SearchTeam` (go-gitea#20844)
  Double check CloneURL is acceptable (go-gitea#20869)
  Fix graceful doc (go-gitea#20883)
  Pad GPG Key ID with preceding zeroes (go-gitea#20878)
  [skip ci] Updated translations via Crowdin
  call builtinUnused() if internal SSH is disabled (go-gitea#20877)
  Don't open new page for ext wiki on same repository (go-gitea#20725)
  [skip ci] Updated translations via Crowdin
  Fix the mode of custom dir to 0700 in docker-rootless (go-gitea#20861)
  Fix UI mis-align for PR commit history (go-gitea#20845)
@zeripath zeripath added the backport/done All backports for this PR have been created label Aug 22, 2022
techknowlogick pushed a commit that referenced this pull request Aug 23, 2022
Backport #20850

This patch fixes the issue that the mirror address field is ignored from the repo setting form.

Co-authored-by: Gary Wang <wzc782970009@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
This patch fixes the issue that the mirror address field is ignored from the repo setting form.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants