Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 13, 2022

Just found webhook send queue is still using a memory one. This PR add that and removed the unused memory queue.

@lunny lunny added the type/enhancement An improvement of existing functionality label Apr 13, 2022
@lunny lunny added this to the 1.17.0 milestone Apr 13, 2022
@delvh delvh added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Apr 13, 2022
@delvh
Copy link
Member

delvh commented Apr 13, 2022

The CI fail sounds related. Somewhere in this PR, there seems to be an NPE.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2022
@lunny
Copy link
Member Author

lunny commented Apr 13, 2022

The CI fail sounds related. Somewhere in this PR, there seems to be an NPE.

Yes, webhook_service.Init should be invoked before some tests, blocked by #19393

@lunny lunny force-pushed the lunny/webhook_queue branch from 589173c to 96dfe20 Compare April 17, 2022 15:55
@lunny lunny force-pushed the lunny/webhook_queue branch from 96dfe20 to 4aa7d9e Compare April 25, 2022 07:05
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2022
@lunny lunny force-pushed the lunny/webhook_queue branch from 93ac146 to 632dfdc Compare April 25, 2022 17:14
@6543
Copy link
Member

6543 commented Apr 25, 2022

🚀

@6543 6543 merged commit 7c164d5 into go-gitea:main Apr 25, 2022
@lunny lunny deleted the lunny/webhook_queue branch April 26, 2022 01:33
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 26, 2022
* giteaofficial/main:
  Add a new menu in file view to open blame view and fix blame view select range bug (go-gitea#19500)
  Fix two UI bugs: JS error in imagediff.js, 500 error in diff/compare.tmpl
  [skip ci] Updated translations via Crowdin
  Improve Stopwatch behavior (go-gitea#18930)
  Pass gitRepo down to GetRawDiff, since its used for main repo and wiki (go-gitea#19461)
  Use queue instead of memory queue in webhook send service (go-gitea#19390)
  add a directory prefix `gitea-src-VERSION` to release-tar-file (go-gitea#19396)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants