Skip to content

Move init repository related functions to modules #19159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 29, 2022
Merged

Move init repository related functions to modules #19159

merged 8 commits into from
Mar 29, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 21, 2022

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 21, 2022
@lunny lunny force-pushed the lunny/move_init_repo branch from ae1372d to 175242c Compare March 22, 2022 08:47
@lunny lunny added this to the 1.17.0 milestone Mar 22, 2022
@lunny lunny force-pushed the lunny/move_init_repo branch from 175242c to a1405ac Compare March 23, 2022 02:25
KN4CK3R
KN4CK3R reviewed Mar 23, 2022
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 23, 2022
@lunny lunny force-pushed the lunny/move_init_repo branch from a1405ac to 29d1851 Compare March 24, 2022 00:49
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a5f2894). Click here to learn what that means.
The diff coverage is 50.56%.

@@           Coverage Diff           @@
##             main   #19159   +/-   ##
=======================================
  Coverage        ?   46.54%           
=======================================
  Files           ?      857           
  Lines           ?   123194           
  Branches        ?        0           
=======================================
  Hits            ?    57344           
  Misses          ?    58906           
  Partials        ?     6944
Impacted Files Coverage Δ
models/error.go 38.78% <ø> (ø)
models/repo.go 53.63% <ø> (ø)
models/repo_generate.go 21.05% <0.00%> (ø)
modules/repository/create.go 42.39% <0.00%> (ø)
routers/api/v1/org/label.go 80.19% <0.00%> (ø)
routers/api/v1/repo/label.go 82.53% <0.00%> (ø)
routers/web/org/org_labels.go 0.00% <0.00%> (ø)
routers/web/org/setting.go 0.00% <0.00%> (ø)
routers/web/repo/issue_label.go 37.17% <0.00%> (ø)
services/repository/adopt.go 26.64% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f2894...29d1851. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2022
@lunny
Copy link
Member Author

lunny commented Mar 29, 2022

make L-G-T-M work

@lunny lunny merged commit 76aa33d into go-gitea:main Mar 29, 2022
@lunny lunny deleted the lunny/move_init_repo branch March 29, 2022 07:23
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 30, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
f6c0470 
* giteaoffical/main: (31 commits)
  Add Package Registry (go-gitea#16510)
  Show messages for users if the ROOT_URL is wrong, show JavaScript errors (go-gitea#18971)
  [skip ci] Updated translations via Crowdin
  Make git.OpenRepository accept Context (go-gitea#19260)
  Use full output of git show-ref --tags to get tags for PushUpdateAddTag (go-gitea#19235)
  When conflicts have been previously detected ensure that they can be resolved (go-gitea#19247)
  More commit info from API (go-gitea#19252)
  Move some issue methods as functions (go-gitea#19255)
  Move project files into models/project sub package (go-gitea#17704)
  Granular webhook events in editHook (go-gitea#19251)
  Provide configuration to allow camo-media proxying (go-gitea#12802)
  Move init repository related functions to modules (go-gitea#19159)
  Move organization related structs into sub package (go-gitea#18518)
  Refactor repo clone button and repo clone links, fix JS error on empty repo page (go-gitea#19208)
  Show last cron messages on monitor page (go-gitea#19223)
  Allow API to create file on empty repo (go-gitea#19224)
  Use goproxy.io instead of goproxy.cn (go-gitea#19242)
  New cron task: delete old system notices (go-gitea#19219)
  Let web and API routes have different auth methods group (go-gitea#19168)
  Only send webhook events to active system webhooks and only deliver to active hooks (go-gitea#19234)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-commenter @KN4CK3R @wxiaoguang @Gusted @GiteaBot