Add warning to set SENDMAIL_ARGS to -- #19102
Conversation
… that interprets options Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Maybe we could just automatically add |
Co-authored-by: silverwind <me@silverwind.io>
Are you able to go through and check EVERY "sendmail" that exists and assert that If not we would need another option to not append the We'd also likely need another option which is to refuse to send emails via sendmail if the email address starts with a |
Can't say that for sure but |
Signed-off-by: Andrew Thornton <art27@cantab.net>
| @@ -666,7 +666,7 @@ Define allowed algorithms and their minimum key length (use -1 to disable a type | |||
| - Enabling dummy will ignore all settings except `ENABLED`, `SUBJECT_PREFIX` and `FROM`. | |||
| - `SENDMAIL_PATH`: **sendmail**: The location of sendmail on the operating system (can be | |||
| command or full path). | |||
| - `SENDMAIL_ARGS`: **_empty_**: Specify any extra sendmail arguments. | |||
| - `SENDMAIL_ARGS`: **_empty_**: Specify any extra sendmail arguments. (NOTE: you should be aware that email addresses can look like options - if your `sendmail` command takes options you must set the option terminator `--`) | |||
There was a problem hiding this comment.
can we add -- by default? (go code)
|
🚀 - merge this first ... we can talk about defaults later |
* giteaoffical/main: remove not needed (go-gitea#19128) Add warning to set SENDMAIL_ARGS to -- (go-gitea#19102) Do not send activation email if manual confirm is set (go-gitea#19119) Update tool dependencies (go-gitea#19120) Delete related notifications on issue deletion too (go-gitea#18953) nit fix (go-gitea#19116) Store the foreign ID of issues during migration (go-gitea#18446) Remove italics for `due_date_not_set` (go-gitea#19113)
Even with go-gitea#17688 email addresses that contain an initial `-` may still be present in the db and it may in future still be possible to imagine a situation whereby initial `-` are repermitted. This PR simply updates the documentation to warn users to set their SENDMAIL_ARGS with a terminal `--` to prevent this possibility email addresses being interpreted as options. Signed-off-by: Andrew Thornton <art27@cantab.net>
Even with #17688 email addresses that contain an initial
-may still be present in the db and it may in future still be possible to imagine a situation whereby initial-are repermitted.This PR simply updates the documentation to warn users to set their SENDMAIL_ARGS with a terminal
--to prevent this possibility email addresses being interpreted as options.Signed-off-by: Andrew Thornton art27@cantab.net