Skip to content

Conversation

wxiaoguang
Copy link
Contributor

Close #19940

I think it needs a break

Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only all problems were that easily fixable...

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 11, 2022
@wxiaoguang
Copy link
Contributor Author

Unfortunately some are not 😭 I have spent many hours on 19930 , even then an auxiliary 19941 😂

@delvh delvh added this to the 1.17.0 milestone Jun 11, 2022
@delvh delvh added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 11, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 12, 2022
@wxiaoguang wxiaoguang merged commit a9dc9b0 into go-gitea:main Jun 12, 2022
@wxiaoguang wxiaoguang deleted the fix-signal-loop branch June 12, 2022 13:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 12, 2022
* giteaoffical/main:
  Fix signal loop in graceful manager (go-gitea#19943)
  Prettify number of issues (go-gitea#17760)
  Improve file header on mobile (go-gitea#19945)
  Unify repo settings & show better error (go-gitea#19828)
  [skip ci] Updated translations via Crowdin
  fixed comment typo (go-gitea#19944)
  Auto merge pull requests when all checks succeeded via WebUI (go-gitea#19648)
  Fix some mirror bugs (go-gitea#18649)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes ^C will generate huge "shutting down" logs during integration test
7 participants