Skip to content

Conversation

Eekle
Copy link
Contributor

@Eekle Eekle commented May 30, 2022

This restyles the user profile page avatar in a mobile environment so that it displays the whole image at 30% of the viewport width

Old:

image

New:
image

@Eekle
Copy link
Contributor Author

Eekle commented May 30, 2022

I don't think the build failure here is due to this change...?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2022
@Eekle
Copy link
Contributor Author

Eekle commented May 30, 2022

There is also the https://semantic-ui.com/views/card.html#text-alignment property which may be a more natural way to do this.

@silverwind
Copy link
Member

Interesting, I thought the object-fit: contain would prevent such clipped images.

@Gusted Gusted added this to the 1.17.0 milestone Jun 5, 2022
@Gusted Gusted added type/enhancement An improvement of existing functionality topic/mobile labels Jun 5, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 8, 2022
@lunny
Copy link
Member

lunny commented Jun 10, 2022

Please update

@wxiaoguang wxiaoguang merged commit 4f1fb0f into go-gitea:main Jun 10, 2022
@Eekle Eekle deleted the userAvatarWidth branch June 10, 2022 11:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 11, 2022
* giteaoffical/main:
  Fix data-race problems in git module (quick patch) (go-gitea#19934)
  [skip ci] Updated translations via Crowdin
  Fix copy/paste of empty lines (go-gitea#19798)
  Normalize line endings in fomantic build files (go-gitea#19932)
  Make user profile image show full image on mobile (go-gitea#19840)
  Custom regexp external issues (go-gitea#17624)
  Use Golang 1.18 for Gitea 1.17 release (go-gitea#19918)
  Refactor git module, make Gitea use internal git config (go-gitea#19732)
  [skip ci] Updated translations via Crowdin
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Make user profile image show full image on mobile
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/mobile type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants