Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented May 28, 2022

No description provided.

@lunny lunny added the type/bug label May 28, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2022
@lunny lunny force-pushed the lunny/fix_order_by branch from 5fbd303 to 407ac14 Compare May 28, 2022 09:32
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 28, 2022
@zeripath
Copy link
Contributor

Ugh this appears to have broken many things.

I'm concerned that the requirement to use .SQL(...) and the weird dialect dance makes this a bit complex and certainly error prone.

I think that we need to think again about the xorm interface - certainly the session.OrderBy(...) function needs to be changed to take interface{} pairs eg. from:

func (session *Session) OrderBy(order string) *Session { ... }

to:

func (session *Session) OrderBy(order interface{}, args ...interface{}) *Session { ... }

Then we need to think a bit more about how builders could pass down the ordering - but I suspect that keeping these separate from the condition would still be right.

@lunny lunny mentioned this pull request May 31, 2022
@lunny lunny closed this May 31, 2022
@lunny lunny deleted the lunny/fix_order_by branch May 31, 2022 11:19
zeripath added a commit that referenced this pull request Jun 4, 2022
Upgrade builder to v0.3.11
Upgrade xorm to v1.3.1 and fixed some hidden bugs.

Replace #19821
Replace #19834
Included #19850

Co-authored-by: zeripath <art27@cantab.net>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
Upgrade builder to v0.3.11
Upgrade xorm to v1.3.1 and fixed some hidden bugs.

Replace go-gitea#19821
Replace go-gitea#19834
Included go-gitea#19850

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants