Skip to content

Delete user related oauth stuff on user deletion too #19677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 11, 2022
Merged

Delete user related oauth stuff on user deletion too #19677

merged 5 commits into from
May 11, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented May 10, 2022

close #19111

@6543 6543 added this to the 1.17.0 milestone May 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022 •
edited
Loading

Codecov Report

Merging #19677 (d0813ad) into main (cbd4547) will decrease coverage by 0.02%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##             main   #19677      +/-   ##
==========================================
- Coverage   47.35%   47.33%   -0.03%     
==========================================
  Files         958      958              
  Lines      133577   133603      +26     
==========================================
- Hits        63256    63239      -17     
- Misses      62666    62707      +41     
- Partials     7655     7657       +2
Impacted Files Coverage Δ
models/user.go 32.35% <0.00%> (-0.73%) ⬇️
modules/doctor/dbconsistency.go 4.54% <0.00%> (-0.25%) ⬇️
models/auth/oauth2.go 62.96% <57.14%> (-0.25%) ⬇️
modules/process/manager_exec.go 85.36% <0.00%> (-7.32%) ⬇️
modules/queue/queue_bytefifo.go 47.29% <0.00%> (-5.78%) ⬇️
models/unit/unit.go 47.00% <0.00%> (-1.71%) ⬇️
modules/queue/workerpool.go 53.62% <0.00%> (-1.04%) ⬇️
routers/web/repo/view.go 40.00% <0.00%> (-0.49%) ⬇️
services/pull/pull.go 40.80% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd4547...d0813ad. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2022
Gusted
Gusted reviewed May 11, 2022
View reviewed changes
delvh
delvh approved these changes May 11, 2022
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2022
@6543 6543 merged commit f41c2be into go-gitea:main May 11, 2022
@6543 6543 deleted the dell-oauth2-stuff branch May 11, 2022 11:16
6543 added a commit to 6543-forks/gitea that referenced this pull request May 11, 2022
@6543
Delete user related oauth stuff on user deletion too (go-gitea#19677)
c0042b3 
* delete user related oauth stuff on user deletion too

* extend doctor check-db-consistency
@6543 6543 mentioned this pull request May 11, 2022
Merged
@6543 6543 added the backport/done All backports for this PR have been created label May 11, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 11, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7ac964a 
* giteaofficial/main:
  Fix oauth setting list bug (go-gitea#19682)
  Delete user related oauth stuff on user deletion too (go-gitea#19677)
  Move access and repo permission to models/perm/access (go-gitea#19350)
  Tidy up `<head>` template (go-gitea#19678)
  Update go tool dependencies (go-gitea#19676)
  Update JS dependencies (go-gitea#19675)
6543 added a commit that referenced this pull request May 12, 2022
@6543
Delete user related oauth stuff on user deletion too (#19677) (#19680)
8f44d00 
Backport (#19677)

* delete user related oauth stuff on user deletion too

* extend doctor check-db-consistency

* make it build for v1.16.x
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@6543 @AbdulrhmnGhanem
Delete user related oauth stuff on user deletion too (go-gitea#19677)
17f28ab 
* delete user related oauth stuff on user deletion too

* extend doctor check-db-consistency
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@Gusted Gusted Gusted left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Deleted accounts leave OAuth tokens valid
6 participants
@6543 @codecov-commenter @lunny @Gusted @delvh @GiteaBot