Skip to content

[doctor] authorized-keys: fix displayed check name #19464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2022
Merged

[doctor] authorized-keys: fix displayed check name #19464

merged 3 commits into from
Apr 24, 2022

Conversation

pilou-
Copy link
Contributor

@pilou- pilou- commented Apr 22, 2022

The registered check name is authorized-keys, not authorized_keys:

$ ./gitea-1.16.5-linux-amd64 --config /etc/gitea/gitea.ini --work-path /srv/gitea doctor --all
[...]
[6] Check if OpenSSH authorized_keys file is up-to-date
 - [C] authorized_keys file "/srv/gitea/.ssh/authorized_keys" is out of date.
	Regenerate it with:
		"gitea admin regenerate keys"
	or
		"gitea doctor --run authorized_keys --fix"
ERROR
[...]
$ gitea-1.16.5-linux-amd64 --config /etc/gitea/gitea.ini --work-path /srv/gitea doctor --run authorized_keys --fix # nothing is done
$ gitea-1.16.5-linux-amd64 --config /etc/gitea/gitea.ini --work-path /srv/gitea doctor --run authorized-keys --fix
[1] Check if OpenSSH authorized_keys file is up-to-date
 - [W] authorized_keys is out of date. Attempting rewrite...
[...]
OK

@pilou-
[doctor] authorized-keys: fix displayed check name
7a80020 
The registered check name is authorized-keys, not authorized_keys.
zeripath
zeripath approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be helpful to make the doctor make "_" and "-" synonymic

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 22, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 22, 2022
@6543 6543 added the type/enhancement An improvement of existing functionality label Apr 22, 2022
@6543 6543 added this to the 1.17.0 milestone Apr 22, 2022
@6543 6543 added type/bug and removed type/enhancement An improvement of existing functionality labels Apr 22, 2022
@6543
Copy link
Member

6543 commented Apr 24, 2022

🚀

@6543 6543 merged commit ebb2396 into go-gitea:main Apr 24, 2022
@6543
Copy link
Member

6543 commented Apr 24, 2022

@pilou- if you like to backport ... feel free to do so

zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
59edd92 
* giteaofficial/main:
  Simplify the code to get issue count (go-gitea#19380)
  use IsLoopback (go-gitea#19477)
  [skip ci] Updated translations via Crowdin
  Add RSS Feed buttons to Repo, User and Org pages (go-gitea#19370)
  [doctor] authorized-keys: fix displayed check name (go-gitea#19464)
  [skip ci] Updated translations via Crowdin
  Use horizontal tabs for repo header on mobile (go-gitea#19468)
pilou- added a commit to pilou-/gitea that referenced this pull request Apr 25, 2022
@pilou-
[doctor] authorized-keys: fix displayed check name (backport go-gitea…
cdf0bb3 
…#19464)

The registered check name is authorized-keys, not authorized_keys.
@pilou-
Copy link
Contributor Author

pilou- commented Apr 25, 2022

@pilou- if you like to backport ... feel free to do so

#19484

@pilou- pilou- deleted the doctor_fix_authorized-keys_in_output branch April 25, 2022 10:10
6543 pushed a commit that referenced this pull request Apr 25, 2022
@pilou-
[doctor] authorized-keys: fix displayed check name (backport #19464) (#…
a6b32ad 
…19484)

The registered check name is authorized-keys, not authorized_keys.
@6543 6543 added the backport/done All backports for this PR have been created label Apr 30, 2022
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@pilou- @AbdulrhmnGhanem
[doctor] authorized-keys: fix displayed check name (go-gitea#19464)
43fdbd1 
The registered check name is authorized-keys, not authorized_keys.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pilou- @6543 @zeripath @wxiaoguang @lunny @GiteaBot