Skip to content

Prevent NPE when viewing non-rendered files #18234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Prevent NPE when viewing non-rendered files #18234

merged 1 commit into from
Jan 11, 2022

Conversation

zeripath
Copy link
Contributor

Fix #18231

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Prevent NPE when viewing non-rendered files
2c2f483 
Fix go-gitea#18231

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 11, 2022
@zeripath zeripath added this to the 1.16.0 milestone Jan 11, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 11, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 11, 2022
@6543 6543 merged commit 09d2029 into go-gitea:main Jan 11, 2022
@zeripath zeripath deleted the fix-18231-prevent-NPE-on-non-rendered-files branch January 11, 2022 17:19
zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Jan 12, 2022
Merge branch 'main' of https://github.com/go-gitea/gitea
67ca2a5 
* 'main' of https://github.com/go-gitea/gitea:
  [doc] https-setup: explain relative paths for {CERT,KEY}_FILE fields. (go-gitea#18244)
  chore: remove unnecessary section (go-gitea#18209)
  Fix purple color in suggested label colors (go-gitea#18241)
  Prevent NPE when viewing non-rendered files (go-gitea#18234)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath
Prevent NPE when viewing non-rendered files (go-gitea#18234)
9d4a3b3 
Fix go-gitea#18231

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

View dll file occupy template render error.
4 participants
@zeripath @lunny @6543 @GiteaBot