Add "Allow edits from maintainer" feature #18002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a feature [like GitHub has](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) if you create a new PR from a forked repo. You can select (and change later, but only if you are the PR creater/poster) the "Allow edits from maintainers" option. Then users with write access to the base branch get more permissions on this branch: * use the update pull request button * push directly from the command line (`git push`) * edit/delete/upload files via web UI You can't merge PRs to this branch. This feature has a pretty big impact on the permission system. I might forgot changing some things or didn't find security vulnerabilities. In this case, please leave a review or comment on this PR. Closes #17728
silverwind
reviewed
Dec 16, 2021
silverwind
reviewed
Dec 16, 2021
silverwind
reviewed
Dec 16, 2021
Co-authored-by: silverwind <me@silverwind.io>
6543
reviewed
Dec 17, 2021
6543
reviewed
Dec 20, 2021
|
@qwerty287 I did help out a bit ... :) |
|
@6543 thanks! |
# Conflicts: # routers/web/repo/issue.go
wxiaoguang
reviewed
Apr 28, 2022
wxiaoguang
reviewed
Apr 28, 2022
6543
approved these changes
Apr 28, 2022
wxiaoguang
approved these changes
Apr 28, 2022
|
Thanks! This was one of the features I missed most in Gitea! |
17 tasks
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 29, 2022
* giteaofficial/main: [skip ci] Updated translations via Crowdin Support `hostname:port` to pass host matcher's check go-gitea#19543 (go-gitea#19543) Add "Allow edits from maintainer" feature (go-gitea#18002) Better describe what `/repos/{owner}/{repo}/raw/{filepath}` returns on 200 (go-gitea#19542) more context for models (go-gitea#19511)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
Adds a feature [like GitHub has](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) (step 7). If you create a new PR from a forked repo, you can select (and change later, but only if you are the PR creator/poster) the "Allow edits from maintainers" option. Then users with write access to the base branch get more permissions on this branch: * use the update pull request button * push directly from the command line (`git push`) * edit/delete/upload files via web UI * use related API endpoints You can't merge PRs to this branch with this enabled, you'll need "full" code write permissions. This feature has a pretty big impact on the permission system. I might forgot changing some things or didn't find security vulnerabilities. In this case, please leave a review or comment on this PR. Closes go-gitea#17728 Co-authored-by: 6543 <6543@obermui.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature like GitHub has (step 7).
If you create a new PR from a forked repo, you can select (and change later, but only if you are the PR creator/poster) the "Allow edits from maintainers" option.
Then users with write access to the base branch get more permissions on this branch:
git push)You can't merge PRs to this branch with this enabled, you'll need "full" code write permissions.
This feature has a pretty big impact on the permission system. I might forgot changing some things or didn't find security vulnerabilities. In this case, please leave a review or comment on this PR.
Closes #17728