Skip to content

Fix admin user list pagination #18957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2022
Merged

Fix admin user list pagination #18957

merged 1 commit into from
Mar 1, 2022

Conversation

fnetX
Copy link
Contributor

@fnetX fnetX commented Mar 1, 2022

The pagination in the admin user list is broken, because the filters aren't applied.

I created a new function, because I suspect that user pagination with filters might be added in other places, too.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 1, 2022
@6543 6543 added this to the 1.17.0 milestone Mar 1, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 1, 2022
@6543 6543 merged commit aee0fa6 into go-gitea:main Mar 1, 2022
@fnetX fnetX mentioned this pull request Mar 1, 2022
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Mar 1, 2022
zeripath pushed a commit that referenced this pull request Mar 1, 2022
@fnetX
Fix admin user list pagination (#18957) (#18960)
36e96e3
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 2, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9a7a780 
* giteaofficial/main:
  Send 404 on `/{org}.gpg` (go-gitea#18959)
  Accounts with WebAuthn only (no TOTP) now exist ... fix code to handle that case (go-gitea#18897)
  Fix lfs management setting (go-gitea#18946)
  Fix admin user list pagination (go-gitea#18957)
@wxiaoguang
Copy link
Contributor

These status_filter[is_active] should only be used on admin page, but now it is set in routers/web/explore/user.go

Would you mind I propose a new PR to do a further refactoring?

@wxiaoguang
Copy link
Contributor

Hmm, I think we had better do a refactoring, otherwise some URLs becomes strange:

https://try.gitea.io/explore/users?page=3&sort=alphabetically&q=&status_filter[is_active]=&status_filter[is_admin]=&status_filter[is_restricted]=&status_filter[is_2fa_enabled]=&status_filter[is_prohibit_login]=

New PR:

@wxiaoguang wxiaoguang mentioned this pull request Mar 2, 2022
Merged
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@fnetX
Fix admin user list pagination (go-gitea#18957)
efe4231
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fnetX @wxiaoguang @6543 @Gusted @GiteaBot