Skip to content

Fix ldap user sync missed email in email_address table (#18786) #18876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix ldap user sync missed email in email_address table (#18786) #18876

merged 2 commits into from
Feb 24, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 24, 2022 •
edited
Loading

backport #18786, #18878

  • Fix ldap user sync missed email in email_address table
  • Fix test

@lunny lunny added the type/bug label Feb 24, 2022
@lunny lunny added this to the 1.16.2 milestone Feb 24, 2022
delvh
delvh reviewed Feb 24, 2022
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2022
lunny added 2 commits February 24, 2022 23:33
@lunny
Fix ldap user sync missed email in email_address table (go-gitea#18786)
b539b38 
* Fix ldap user sync missed email in email_address table

* Fix test
@lunny
Fix update user bug
08f1f9d
@lunny lunny force-pushed the lunny/fix_ldap_emails2 branch from d4e6907 to 08f1f9d Compare February 24, 2022 15:33
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2022
@6543 6543 merged commit 3685cc7 into go-gitea:release/v1.16 Feb 24, 2022
@lunny lunny deleted the lunny/fix_ldap_emails2 branch February 25, 2022 06:49
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

+1 more reviewer

@richmahn richmahn richmahn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.16.2
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @richmahn @delvh @GiteaBot @6543