Skip to content

Fix problem when self-assign notification #18797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2022
Merged

Fix problem when self-assign notification #18797

merged 3 commits into from
Feb 18, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 17, 2022

No description provided.

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Feb 17, 2022
@lunny lunny added this to the 1.17.0 milestone Feb 17, 2022
Gusted
Gusted approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@Gusted Gusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible there are more instances like these?

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 17, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2022
@lunny
Copy link
Member Author

lunny commented Feb 18, 2022

Is it possible there are more instances like these?

Should we also ignore them for sending mail notification?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@6767798). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18797   +/-   ##
=======================================
  Coverage        ?   46.61%           
=======================================
  Files           ?      853           
  Lines           ?   122463           
  Branches        ?        0           
=======================================
  Hits            ?    57080           
  Misses          ?    58501           
  Partials        ?     6882
Impacted Files Coverage Δ
modules/notification/ui/ui.go 60.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6767798...8394f7d. Read the comment docs.

@lunny lunny merged commit a7b9d44 into go-gitea:main Feb 18, 2022
@lunny lunny deleted the lunny/fix_self_assign_notification branch February 18, 2022 06:07
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 18, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
385b697 
* giteaofficial/main:
  Fix ldap loginname (go-gitea#18789)
  Replace deprecated String.prototype.substr() with String.prototype.slice() (go-gitea#18796)
  Fix problem when self-assign notification (go-gitea#18797)
  Move editorconfig-checker to lint-backend and remove JS wrapper (go-gitea#18793)
@fnetX fnetX mentioned this pull request Mar 2, 2022
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Mar 2, 2022
zeripath pushed a commit that referenced this pull request Mar 2, 2022
@fnetX @lunny
Fix problem when self-assign notification (#18797) (#18976)
a3f7230 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny
Fix problem when self-assign notification (go-gitea#18797)
07907e4
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @codecov-commenter @KN4CK3R @Gusted @delvh @GiteaBot @6543