Move editorconfig-checker to lint-backend and remove JS wrapper #18793
Conversation
It makes more sense there as templates are considered backend code.
217828b to
7c3a2fd
Compare
|
Hmm this isn't so easy because the command depends on node and npx presence which isn't there in some docker images used on the CI. I guess we should probably just keep it in |
|
The |
|
|
|
Ready for review. Now this directly uses the golang tool, eliminating the JS wrapper and a bunch of indirect npm dependencies as well. |
There was a problem hiding this comment.
This should also be added to the test environment: https://gitea.com/gitea/test-env just like golangci-lint
|
I still hope that golang some day will provide a solution to define devDependencies in |
* giteaofficial/main: Fix ldap loginname (go-gitea#18789) Replace deprecated String.prototype.substr() with String.prototype.slice() (go-gitea#18796) Fix problem when self-assign notification (go-gitea#18797) Move editorconfig-checker to lint-backend and remove JS wrapper (go-gitea#18793)
…itea#18793) * Move editorconfig-checker to lint-backend It makes more sense there as templates are considered backend code. * User golang version of the tool * remove dependency
It makes more sense there as templates are considered backend code.