Fix ldap user sync missed email in email_address table #18786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If old email address source is LDAP, it should be deleted |
zeripath
approved these changes
Feb 16, 2022
|
CI failure is related |
We don't know that. LDAP user could add a new email address and change the primary email. So let it be and user could delete the old email manually. |
326bd00 to
37d8a7b
Compare
Codecov Report
@@ Coverage Diff @@
## main #18786 +/- ##
=======================================
Coverage ? 46.61%
=======================================
Files ? 853
Lines ? 122512
Branches ? 0
=======================================
Hits ? 57111
Misses ? 58507
Partials ? 6894
Continue to review full report at Codecov.
|
silverwind
approved these changes
Feb 24, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 24, 2022
* giteaofficial/main: Fix ldap user sync missed email in email_address table (go-gitea#18786) Update assignees check to include any writing team and change org sidebar (go-gitea#18680) Set max text height to prevent overflow (go-gitea#18862) Lock gofumpt to v0.3.0 and run it (go-gitea#18866)
zeripath
reviewed
Feb 24, 2022
| IsActivated: true, | ||
| IsPrimary: true, | ||
| }) | ||
| return err |
There was a problem hiding this comment.
this should be if err != nil {
Merged
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Feb 24, 2022
* Fix ldap user sync missed email in email_address table * Fix test
6543
pushed a commit
that referenced
this pull request
Feb 24, 2022
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Fix ldap user sync missed email in email_address table * Fix test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #18603 . Should we keep the old email address or delete it when sync user with new email from ldap?