Skip to content

Enforce netgo build tag while cross-compilation (backport #1690) #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2017
Merged

Enforce netgo build tag while cross-compilation (backport #1690) #1731

merged 1 commit into from
May 18, 2017

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented May 15, 2017

As title

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 15, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 15, 2017
@bkcsoft
Copy link
Member

bkcsoft commented May 15, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 15, 2017
@bkcsoft
Copy link
Member

bkcsoft commented May 15, 2017

make lg-tm work

@lunny lunny added this to the 1.1.2 milestone May 16, 2017
@lunny lunny added the type/bug label May 16, 2017
@lunny
Copy link
Member

lunny commented May 17, 2017

@cez81 could you rebase this? I will merge it.

@cez81
Copy link
Contributor Author

cez81 commented May 17, 2017

@lunny Done

@lunny lunny merged commit daaabaa into go-gitea:release/v1.1 May 18, 2017
@cez81 cez81 deleted the backport_1690 branch May 18, 2017 09:42
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@cez81 @appleboy @bkcsoft @lunny @tboerger