Add caller to cat-file batch calls #17082

zeripath · 2021-09-17T21:00:41Z

Some people still appear to report unclosed cat-files. This PR simply adds the caller
to the process descriptor for the CatFileBatch and CatFileBatchCheck calls.

Signed-off-by: Andrew Thornton art27@cantab.net

Some people still appear to report unclosed cat-files. This PR simply adds the caller to the process descriptor for the CatFileBatch and CatFileBatchCheck calls. Signed-off-by: Andrew Thornton <art27@cantab.net>

codecov-commenter · 2021-09-17T21:21:14Z

Codecov Report

Merging #17082 (40f63b5) into main (e2f0ab3) will increase coverage by 0.03%.
The diff coverage is 41.73%.

@@            Coverage Diff             @@
##             main   #17082      +/-   ##
==========================================
+ Coverage   45.23%   45.26%   +0.03%     
==========================================
  Files         766      771       +5     
  Lines       86706    86764      +58     
==========================================
+ Hits        39220    39278      +58     
+ Misses      41139    41133       -6     
- Partials     6347     6353       +6

Impacted Files	Coverage Δ
cmd/admin_auth_ldap.go	`76.47% <0.00%> (-1.15%)`	⬇️
modules/context/api.go	`74.17% <0.00%> (-0.71%)`	⬇️
modules/context/auth.go	`19.81% <0.00%> (-0.37%)`	⬇️
modules/migrations/github.go	`68.29% <0.00%> (-0.39%)`	⬇️
routers/api/v1/notify/user.go	`14.00% <0.00%> (-0.59%)`	⬇️
routers/api/v1/repo/file.go	`62.21% <0.00%> (-0.29%)`	⬇️
routers/private/hook_verification.go	`0.00% <0.00%> (ø)`
routers/web/user/auth_openid.go	`0.00% <0.00%> (ø)`
routers/web/user/notification.go	`37.71% <0.00%> (ø)`
routers/web/user/setting/account.go	`25.00% <0.00%> (ø)`
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693bea9...40f63b5. Read the comment docs.

zeripath · 2021-09-17T21:34:16Z

The idea is that we can find where the calls are being made and then more closely investigate.

Some people still appear to report unclosed cat-files. This PR simply adds the caller to the process descriptor for the CatFileBatch and CatFileBatchCheck calls. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

## [1.15.3](https://github.com/go-gitea/gitea/releases/tag/v1.15.3) - 2021-09-19 * ENHANCEMENTS * Add fluid to ui container class to remove margin (go-gitea#16396) (go-gitea#16976) * Add caller to cat-file batch calls (go-gitea#17082) (go-gitea#17089) * BUGFIXES * Render full plain readme. (go-gitea#17083) (go-gitea#17090) * Upgrade xorm to v1.2.4 (go-gitea#17059) * Fix bug of migrate comments which only fetch one page (go-gitea#17055) (go-gitea#17058) * Do not show issue context popup on external issues (go-gitea#17050) (go-gitea#17054) * Decrement Fork Num when converting from Fork (go-gitea#17035) (go-gitea#17046) * Correctly rollback in ForkRepository (go-gitea#17034) (go-gitea#17045) * Fix missing close in WalkGitLog (go-gitea#17008) (go-gitea#17009) * Add prefix to SVG id/class attributes (go-gitea#16997) (go-gitea#17000) * Fix bug of migrated repository not index (go-gitea#16991) (go-gitea#16996) * Skip AllowedUserVisibilityModes validation on update user if it is an organisation (go-gitea#16988) (go-gitea#16990) * Fix storage Iterate bug and Add storage doctor to delete garbage attachments (go-gitea#16971) (go-gitea#16977) * Fix issue with issue default mail template (go-gitea#16956) (go-gitea#16975) * Ensure that rebase conflicts are handled in updates (go-gitea#16952) (go-gitea#16960) * Prevent panic on diff generation (go-gitea#16950) (go-gitea#16951) Signed-off-by: Andrew Thornton <art27@cantab.net>

wxiaoguang · 2021-09-19T14:15:09Z

I caught the cat-file logs, these tasks have been runing for 3 hours.

/usr/bin/git cat-file --batch [repo_path: /data/git/repositories/our-team/our-repo.git] (modules/indexer/stats/db.go:32)
/usr/bin/git cat-file --batch-check [repo_path: /data/git/repositories/our-team/our-repo.git] (modules/indexer/stats/db.go:32)

On the server, I can not find any git cat-file related process.

Some people still appear to report unclosed cat-files. This PR simply adds the caller to the process descriptor for the CatFileBatch and CatFileBatchCheck calls. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

## [1.15.3](https://github.com/go-gitea/gitea/releases/tag/v1.15.3) - 2021-09-19 * ENHANCEMENTS * Add fluid to ui container class to remove margin (#16396) (#16976) * Add caller to cat-file batch calls (#17082) (#17089) * BUGFIXES * Render full plain readme. (#17083) (#17090) * Upgrade xorm to v1.2.4 (#17059) * Fix bug of migrate comments which only fetch one page (#17055) (#17058) * Do not show issue context popup on external issues (#17050) (#17054) * Decrement Fork Num when converting from Fork (#17035) (#17046) * Correctly rollback in ForkRepository (#17034) (#17045) * Fix missing close in WalkGitLog (#17008) (#17009) * Add prefix to SVG id/class attributes (#16997) (#17000) * Fix bug of migrated repository not index (#16991) (#16996) * Skip AllowedUserVisibilityModes validation on update user if it is an organisation (#16988) (#16990) * Fix storage Iterate bug and Add storage doctor to delete garbage attachments (#16971) (#16977) * Fix issue with issue default mail template (#16956) (#16975) * Ensure that rebase conflicts are handled in updates (#16952) (#16960) * Prevent panic on diff generation (#16950) (#16951) Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

axifive · 2021-09-20T11:20:43Z

I caught the cat-file logs, these tasks have been runing for 3 hours.
/usr/bin/git cat-file --batch [repo_path: /data/git/repositories/our-team/our-repo.git] (modules/indexer/stats/db.go:32)
/usr/bin/git cat-file --batch-check [repo_path: /data/git/repositories/our-team/our-repo.git] (modules/indexer/stats/db.go:32)
On the server, I can not find any git cat-file related process.

@zeripath

zeripath · 2021-09-20T19:48:34Z

Dealt with and fixed

## [1.15.3](https://github.com/go-gitea/gitea/releases/tag/v1.15.3) - 2021-09-19 * ENHANCEMENTS * Add fluid to ui container class to remove margin (go-gitea#16396) (go-gitea#16976) * Add caller to cat-file batch calls (go-gitea#17082) (go-gitea#17089) * BUGFIXES * Render full plain readme. (go-gitea#17083) (go-gitea#17090) * Upgrade xorm to v1.2.4 (go-gitea#17059) * Fix bug of migrate comments which only fetch one page (go-gitea#17055) (go-gitea#17058) * Do not show issue context popup on external issues (go-gitea#17050) (go-gitea#17054) * Decrement Fork Num when converting from Fork (go-gitea#17035) (go-gitea#17046) * Correctly rollback in ForkRepository (go-gitea#17034) (go-gitea#17045) * Fix missing close in WalkGitLog (go-gitea#17008) (go-gitea#17009) * Add prefix to SVG id/class attributes (go-gitea#16997) (go-gitea#17000) * Fix bug of migrated repository not index (go-gitea#16991) (go-gitea#16996) * Skip AllowedUserVisibilityModes validation on update user if it is an organisation (go-gitea#16988) (go-gitea#16990) * Fix storage Iterate bug and Add storage doctor to delete garbage attachments (go-gitea#16971) (go-gitea#16977) * Fix issue with issue default mail template (go-gitea#16956) (go-gitea#16975) * Ensure that rebase conflicts are handled in updates (go-gitea#16952) (go-gitea#16960) * Prevent panic on diff generation (go-gitea#16950) (go-gitea#16951) Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

## [1.15.3](https://github.com/go-gitea/gitea/releases/tag/v1.15.3) - 2021-09-19 * ENHANCEMENTS * Add fluid to ui container class to remove margin (#16396) (#16976) * Add caller to cat-file batch calls (#17082) (#17089) * BUGFIXES * Render full plain readme. (#17083) (#17090) * Upgrade xorm to v1.2.4 (#17059) * Fix bug of migrate comments which only fetch one page (#17055) (#17058) * Do not show issue context popup on external issues (#17050) (#17054) * Decrement Fork Num when converting from Fork (#17035) (#17046) * Correctly rollback in ForkRepository (#17034) (#17045) * Fix missing close in WalkGitLog (#17008) (#17009) * Add prefix to SVG id/class attributes (#16997) (#17000) * Fix bug of migrated repository not index (#16991) (#16996) * Skip AllowedUserVisibilityModes validation on update user if it is an organisation (#16988) (#16990) * Fix storage Iterate bug and Add storage doctor to delete garbage attachments (#16971) (#16977) * Fix issue with issue default mail template (#16956) (#16975) * Ensure that rebase conflicts are handled in updates (#16952) (#16960) * Prevent panic on diff generation (#16950) (#16951) Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Add caller to cat-file batch calls

a83d1dc

Some people still appear to report unclosed cat-files. This PR simply adds the caller to the process descriptor for the CatFileBatch and CatFileBatchCheck calls. Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added type/enhancement An improvement of existing functionality backport/v1.15 labels Sep 17, 2021

zeripath added this to the 1.16.0 milestone Sep 17, 2021

lafriks approved these changes Sep 17, 2021

View reviewed changes

GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 17, 2021

Merge branch 'main' into add-caller-to-cat-file-calls

42ff08a

techknowlogick approved these changes Sep 17, 2021

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 17, 2021

Merge branch 'main' into add-caller-to-cat-file-calls

40f63b5

techknowlogick merged commit 2553365 into go-gitea:main Sep 18, 2021

zeripath deleted the add-caller-to-cat-file-calls branch September 19, 2021 11:01

zeripath mentioned this pull request Sep 19, 2021

Add caller to cat-file batch calls (#17082) #17089

Merged

zeripath added the backport/done All backports for this PR have been created label Sep 19, 2021

zeripath mentioned this pull request Sep 19, 2021

Changelog 1.15.3 #17091

Merged

This was referenced Sep 19, 2021

CheckAttributeReader.CheckPath hangs forever, and make the background process never end #17094

Closed

Ignore Sync errors on pipes when doing CheckAttributeReader.CheckPath, fix the hang of git cat-file #17096

Merged

go-gitea locked and limited conversation to collaborators Oct 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add caller to cat-file batch calls #17082

Add caller to cat-file batch calls #17082

Uh oh!

zeripath commented Sep 17, 2021

Uh oh!

codecov-commenter commented Sep 17, 2021 •

edited

Loading

Uh oh!

zeripath commented Sep 17, 2021

Uh oh!

wxiaoguang commented Sep 19, 2021 •

edited

Loading

Uh oh!

axifive commented Sep 20, 2021

Uh oh!

zeripath commented Sep 20, 2021

Uh oh!

Uh oh!

Uh oh!

Add caller to cat-file batch calls #17082

Add caller to cat-file batch calls #17082

Uh oh!

Conversation

zeripath commented Sep 17, 2021

Uh oh!

codecov-commenter commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zeripath commented Sep 17, 2021

Uh oh!

wxiaoguang commented Sep 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

axifive commented Sep 20, 2021

Uh oh!

zeripath commented Sep 20, 2021

Uh oh!

Uh oh!

codecov-commenter commented Sep 17, 2021 •

edited

Loading

wxiaoguang commented Sep 19, 2021 •

edited

Loading