Add filter option for subscribed issues #17053
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed it now. You can review this PR :) |
Codecov Report
@@ Coverage Diff @@
## main #17053 +/- ##
==========================================
- Coverage 45.31% 45.30% -0.01%
==========================================
Files 773 773
Lines 86873 86907 +34
==========================================
+ Hits 39366 39376 +10
- Misses 41151 41170 +19
- Partials 6356 6361 +5
Continue to review full report at Codecov.
|
|
Closing this as it's better solved by #17156 |
lafriks
added a commit
that referenced
this pull request
Sep 29, 2022
Adds GitHub-like pages to view watched repos and subscribed issues/PRs This is my second try to fix this, but it is better than the first since it doesn't uses a filter option which could be slow when accessing `/issues` or `/pulls` and it shows both pulls and issues (the first try is #17053). Closes #16111 Replaces and closes #17053  Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a filter option "subscribed" to the
/issuesoverview and to the lists in in the repos (and to the API). Addresses #16111 (and closes the first part of it).I know that the SQL command here is a very long and complex SQL command, but I didn't find another working way (I don't know enough about these xorm.Session conditions) and it works. The command just filters the issues if they are in the
issue_watchtable andis_watchingis 1 or if they are in thecommenttable but not in the list of issues inissue_watchwhereis_watchingis 0 or if they are in theissuestable but not in the list of issues inissue_watchwhereis_watchingis 0. If you know another way how to make this more readable, it would be nice if you could comment.