Skip to content

Add AbsoluteListOptions #17028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 14, 2021
Merged

Add AbsoluteListOptions #17028

merged 4 commits into from
Sep 14, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Sep 12, 2021

This PR adds a ListOptions type which is not paged but uses absolute values. It is implemented as discussed in Discord.
Extracted from #16510 to clean that PR.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021 •
edited
Loading

Codecov Report

Merging #17028 (cccb03a) into main (efdbba4) will increase coverage by 0.07%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17028      +/-   ##
==========================================
+ Coverage   45.15%   45.23%   +0.07%     
==========================================
  Files         765      766       +1     
  Lines       86298    86644     +346     
==========================================
+ Hits        38969    39190     +221     
- Misses      41023    41110      +87     
- Partials     6306     6344      +38
Impacted Files Coverage Δ
models/gpg_key.go 63.76% <0.00%> (ø)
models/issue_label.go 68.29% <0.00%> (ø)
models/issue_reaction.go 82.68% <0.00%> (ø)
models/issue_stopwatch.go 69.92% <0.00%> (ø)
models/issue_tracked_time.go 70.83% <0.00%> (ø)
models/issue_watch.go 75.38% <0.00%> (ø)
models/notification.go 65.13% <0.00%> (ø)
models/oauth2_application.go 68.96% <0.00%> (ø)
models/org_team.go 55.19% <0.00%> (ø)
models/repo_collaboration.go 58.62% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdbba4...cccb03a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 12, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 12, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 12, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Sep 12, 2021
techknowlogick
techknowlogick reviewed Sep 12, 2021
View reviewed changes
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 87505a9 into go-gitea:main Sep 14, 2021
@KN4CK3R KN4CK3R deleted the refactor-paginator branch September 14, 2021 19:58
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@zeripath zeripath added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/enhancement An improvement of existing functionality labels Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

+2 more reviewers

@axifive axifive axifive approved these changes

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@KN4CK3R @codecov-commenter @zeripath @techknowlogick @axifive @GiteaBot @6543