Skip to content

Use fmt.Sprintf correctly #17886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2021
Merged

Use fmt.Sprintf correctly #17886

merged 2 commits into from
Dec 2, 2021

Conversation

delvh
Copy link
Member

@delvh delvh commented Dec 2, 2021

Previously, String concatenation was mixed into fmt.Sprintf in some places.
Refactored those places to only use fmt.Sprintf.

@delvh delvh added type/refactoring Existing code has been cleaned up. There should be no new functionality. priority/low labels Dec 2, 2021
@delvh delvh added this to the 1.16.0 milestone Dec 2, 2021
@delvh delvh mentioned this pull request Dec 2, 2021
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2021
@6543 6543 merged commit 4646c7c into go-gitea:main Dec 2, 2021
@delvh delvh deleted the correct-sprintf branch December 2, 2021 19:37
@delvh delvh added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 2, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@delvh
Use fmt.Sprintf correctly (go-gitea#17886)
c589fb6
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@delvh @techknowlogick @zeripath @6543 @jolheiser @GiteaBot