Skip to content

Extract constant names out for the ReverseProxy and Basic authentication methods #17735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2021
Merged

Extract constant names out for the ReverseProxy and Basic authentication methods #17735

merged 3 commits into from
Nov 20, 2021

Conversation

zeripath
Copy link
Contributor

In order to reduce load on the GC extract out the constant names of the Basic and
ReverseProxy methods.

As mentioned in #15119 (comment)

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Extract constant names out for the ReverseProxy and Basic authenticat…
08f57c7 
…ion methods

In order to reduce load on the GC extract out the constant names of the Basic and
ReverseProxy methods.

As mentioned in go-gitea#15119 (comment)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 20, 2021
@zeripath zeripath added this to the 1.16.0 milestone Nov 20, 2021
lunny
lunny reviewed Nov 20, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 20, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 20, 2021
@wxiaoguang wxiaoguang merged commit f8ec43d into go-gitea:main Nov 20, 2021
@zeripath zeripath deleted the fix-comment-on-15119 branch November 20, 2021 16:13
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath
Extract constant names out for the ReverseProxy and Basic authenticat…
e59836b 
…ion methods (go-gitea#17735)

In order to reduce load on the GC extract out the constant names of the Basic and ReverseProxy methods.

As mentioned in go-gitea#15119 (comment)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @lunny @wxiaoguang @GiteaBot