Skip to content

A better go code formatter, and now make fmt can run in Windows #17684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 17, 2021
Merged

A better go code formatter, and now make fmt can run in Windows #17684

merged 5 commits into from
Nov 17, 2021

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 17, 2021 •
edited
Loading

This PR can fix the bug (now the files are feed to the gofmt/misspell batch by batch)

And we introduce a new (better) go import formatter. gofmt/goimports can not group the imports correctly, our formatter can.

@wxiaoguang wxiaoguang added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/code-linting and removed topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Nov 17, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 17, 2021
@wxiaoguang wxiaoguang linked an issue Nov 17, 2021 that may be closed by this pull request
"make fmt" fails on windows #14438
Closed
lunny
lunny reviewed Nov 17, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 17, 2021
lunny
lunny reviewed Nov 17, 2021
View reviewed changes
lunny
lunny reviewed Nov 17, 2021
View reviewed changes
lunny
lunny reviewed Nov 17, 2021
View reviewed changes
lunny
lunny reviewed Nov 17, 2021
View reviewed changes
lunny
lunny reviewed Nov 17, 2021
View reviewed changes
lunny
lunny reviewed Nov 17, 2021
View reviewed changes
@wxiaoguang
re-format
acb0007
@wxiaoguang
Merge branch 'main' into build-make-format
f2cbd4f 
# Conflicts:
#	models/user_follow_test.go
@wxiaoguang wxiaoguang requested a review from lunny November 17, 2021 10:07
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 17, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 17, 2021
@wxiaoguang wxiaoguang merged commit 750a846 into go-gitea:main Nov 17, 2021
@wxiaoguang wxiaoguang deleted the build-make-format branch November 17, 2021 12:34
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 17, 2021
@wxiaoguang wxiaoguang mentioned this pull request Nov 26, 2021
Closed
@wxiaoguang wxiaoguang mentioned this pull request Nov 26, 2021
Merged
@wxiaoguang wxiaoguang mentioned this pull request Jan 1, 2022
Merged
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
A better go code formatter, and now make fmt can run in Windows (go…
90ecf26 
…-gitea#17684)

* go build / format tools
* re-format imports
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/code-linting
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

"make fmt" fails on windows
4 participants
@wxiaoguang @lunny @lafriks @GiteaBot