Skip to content

Conversation

wxiaoguang
Copy link
Contributor

This PR follows #17623

Now, all unit test code are fully decoupled. And the intermediate interfaces and packages (unittestbridge) are removed.

This PR is based on lunny's #17633, much work is done by that PR, and hopefully this PR can replace that one.

@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 16, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 16, 2021
@wxiaoguang wxiaoguang requested review from lunny and KN4CK3R November 16, 2021 06:55
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2021
Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast 👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2021
@wxiaoguang wxiaoguang merged commit 81926d6 into go-gitea:main Nov 16, 2021
@wxiaoguang wxiaoguang deleted the decouple-unit-test branch November 16, 2021 08:53
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants