Skip to content

Fix 500 when a comment was deleted which has a notification #17550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2021
Merged

Fix 500 when a comment was deleted which has a notification #17550

merged 4 commits into from
Nov 10, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 4, 2021

Fix #17499

@lunny lunny added the type/bug label Nov 4, 2021
delvh
delvh reviewed Nov 4, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2021
@zeripath

This comment has been minimized.

Sign in to view
@lunny

This comment has been minimized.

Sign in to view
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 5, 2021
@lunny lunny added this to the 1.16.0 milestone Nov 5, 2021
@zeripath

This comment has been minimized.

Sign in to view
@zeripath
Tolerate missing Comment in other places too
69bacea 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2021
@zeripath
Copy link
Contributor

zeripath commented Nov 6, 2021

I've added a few other places we can ignore the error too.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2021
@lunny
Copy link
Member Author

lunny commented Nov 10, 2021

make L-G-T-M work.

@lunny lunny merged commit 43bbc54 into go-gitea:main Nov 10, 2021
@lunny lunny deleted the lunny/fix_notification_miss_comment branch November 10, 2021 05:48
@eladyn eladyn mentioned this pull request Mar 1, 2022
Merged
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @zeripath @wxiaoguang
Fix 500 when a comment was deleted which has a notification (go-gitea…
531fdb0 
…#17550)

* Fix 500 when a comment was deleted which has a notification

* Tolerate missing Comment in other places too

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

[API] notifcations API returns 500 if comment was deleted
5 participants
@lunny @zeripath @wxiaoguang @delvh @GiteaBot