Only allow webhook to send requests to allowed hosts (backport #17482) #17510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Nov 1, 2021
"the three extra lines you deleted": What lines do you mean? |
lafriks
requested changes
Nov 2, 2021
lunny
reviewed
Nov 3, 2021
richmahn
approved these changes
Nov 5, 2021
|
@lafriks awaiting your review |
lafriks
approved these changes
Nov 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #17482 (as requested in the PR)
For security reasons, the webhook should only send requests to allowed hosts.
This PR introduces a setting option:
ALLOWED_HOST_LIST: external: Webhook can only call allowed hosts for security reasons. Comma separated list:loopback,private,external, or*, or CIDR list (1.2.3.0/8), or wildcard hosts (*.mydomain.com)