Skip to content

Limit stdout tracelog to actual stdout #16258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2021
Merged

Limit stdout tracelog to actual stdout #16258

merged 3 commits into from
Jun 26, 2021

Conversation

zeripath
Copy link
Contributor

Related #16243

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Limit stdout tracelog to actual stdout
c7ec21a 
Related go-gitea#16243

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 26, 2021
@zeripath zeripath added this to the 1.15.0 milestone Jun 26, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2021 •
edited
Loading

Codecov Report

Merging #16258 (bcfb9e4) into main (e3c6268) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16258      +/-   ##
==========================================
- Coverage   45.47%   45.44%   -0.03%     
==========================================
  Files         709      709              
  Lines       83418    83421       +3     
==========================================
- Hits        37933    37913      -20     
- Misses      39413    39427      +14     
- Partials     6072     6081       +9
Impacted Files Coverage Δ
modules/git/command.go 90.09% <50.00%> (-1.58%) ⬇️
modules/queue/queue_channel.go 91.66% <0.00%> (-5.00%) ⬇️
services/pull/check.go 26.20% <0.00%> (-2.07%) ⬇️
modules/queue/workerpool.go 53.05% <0.00%> (-1.91%) ⬇️
modules/notification/ui/ui.go 60.86% <0.00%> (-1.45%) ⬇️
modules/notification/mail/mail.go 35.29% <0.00%> (-0.99%) ⬇️
models/notification.go 64.97% <0.00%> (-0.89%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
models/error.go 38.91% <0.00%> (-0.78%) ⬇️
modules/avatar/avatar.go 52.27% <0.00%> (+4.54%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c6268...bcfb9e4. Read the comment docs.

@zeripath zeripath added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Jun 26, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 26, 2021
@zeripath zeripath merged commit 19ac575 into go-gitea:main Jun 26, 2021
@zeripath zeripath deleted the only-log-actual-stdout branch June 26, 2021 12:47
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @AbdulrhmnGhanem
Limit stdout tracelog to actual stdout (go-gitea#16258)
baf6c3c 
Related go-gitea#16243

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@noerw noerw noerw approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @codecov-commenter @lunny @noerw @GiteaBot @6543