Skip to content

Fix bug due to missing MaxStartups and MaxSessions #16046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2021
Merged

Fix bug due to missing MaxStartups and MaxSessions #16046

merged 2 commits into from
Jun 1, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Jun 1, 2021

Unforunately #16009 makes these settings mandatory. This PR uses the same technique
as used for the certificates to make these settings non-mandatory.

Fix #16044

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix bug due to missing MaxStartups and MaxSessions
024ae5c 
Unforunately go-gitea#16009 makes these settings mandatory. This PR uses the same technique
as used for the certificates to make these settings non-mandatory.

Fix go-gitea#16044

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. theme/docker labels Jun 1, 2021
@zeripath zeripath added this to the 1.15.0 milestone Jun 1, 2021
@zeripath zeripath added the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label Jun 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 1, 2021
@techknowlogick techknowlogick merged commit 8947422 into go-gitea:main Jun 1, 2021
@zeripath zeripath deleted the fix-16044-sshd-failure branch June 1, 2021 20:29
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @6543 @AbdulrhmnGhanem
Fix bug due to missing MaxStartups and MaxSessions (go-gitea#16046)
43f5f89 
Unforunately go-gitea#16009 makes these settings mandatory. This PR uses the same technique
as used for the certificates to make these settings non-mandatory.

Fix go-gitea#16044

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@delvh delvh added topic/distribution This PR changes something about the packaging of Gitea and removed theme/docker labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/distribution This PR changes something about the packaging of Gitea type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Gitea docker container's SSHD fails due to missing MaxStartups and MaxSessions in sshd_config
5 participants
@zeripath @techknowlogick @6543 @GiteaBot @delvh