Skip to content

Download LFS in git and web workflow from minio/s3 directly (SERVE_DIRECT) #16731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2021
Merged

Download LFS in git and web workflow from minio/s3 directly (SERVE_DIRECT) #16731

merged 2 commits into from
Aug 21, 2021
+20 −0

Conversation

ABNER-1
Copy link
Contributor

@ABNER-1 ABNER-1 commented Aug 19, 2021

Support SERVE_DIRECT config filed for lfs download.
Return a minio/s3 link when SERVE_DIRECT enabled in git & web workflow.

Issue #16711

@ABNER-1 ABNER-1 force-pushed the gitea_lfs_serve_direct branch from f200407 to 8a8f5df Compare August 19, 2021 08:29
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 19, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 19, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2021
@6543 6543 added this to the 1.16.0 milestone Aug 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16731 (81d7204) into main (06f8264) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16731      +/-   ##
==========================================
- Coverage   45.36%   45.21%   -0.16%     
==========================================
  Files         760      760              
  Lines       85495    85504       +9     
==========================================
- Hits        38786    38659     -127     
- Misses      40425    40591     +166     
+ Partials     6284     6254      -30
Impacted Files Coverage Δ
routers/web/repo/download.go 28.20% <0.00%> (-1.94%) ⬇️
services/lfs/server.go 69.50% <0.00%> (-0.93%) ⬇️
services/wiki/wiki.go 0.00% <0.00%> (-58.46%) ⬇️
services/pull/temp_repo.go 30.76% <0.00%> (-3.85%) ⬇️
services/pull/check.go 25.51% <0.00%> (-2.76%) ⬇️
services/repository/transfer.go 54.71% <0.00%> (-1.89%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
modules/queue/workerpool.go 54.58% <0.00%> (-1.15%) ⬇️
services/pull/pull.go 41.78% <0.00%> (ø)
models/repo_list.go 78.43% <0.00%> (+0.78%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f8264...81d7204. Read the comment docs.

@6543
Copy link
Member

6543 commented Aug 21, 2021

🚀

@6543 6543 merged commit 7844bf1 into go-gitea:main Aug 21, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@zeripath zeripath changed the title download lfs in git and web workflow from minio/s3 directly (SERVE_DIRECT) Download LFS in git and web workflow from minio/s3 directly (SERVE_DIRECT) Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ABNER-1 @codecov-commenter @6543 @lunny @GiteaBot