Skip to content

Fix crash following ldap authentication update (#16447) #16449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2021
Merged

Fix crash following ldap authentication update (#16447) #16449

merged 1 commit into from
Jul 16, 2021

Conversation

zeripath
Copy link
Contributor

Backport #16447

Unfortunately #16268 contained a terrible error, whereby there was a double
indirection taken when unmarshalling the source data. This fatally breaks
authentication configuration reading.

Fix #16342

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix crash following ldap authentication update (go-gitea#16447)
f5f36e6 
Backport go-gitea#16447

Unfortunately go-gitea#16268 contained a terrible error, whereby there was a double
indirection taken when unmarshalling the source data. This fatally breaks
authentication configuration reading.

Fix go-gitea#16342

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Jul 15, 2021
@zeripath zeripath added this to the 1.14.5 milestone Jul 15, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 15, 2021
zeripath added a commit to zeripath/gitea that referenced this pull request Jul 15, 2021
@zeripath
Changelog for v1.14.5
5bfd81c 
Once go-gitea#16449 is merged I think we should release 1.14.5. There are a couple of
security fixes and the broken go-gitea#16268 is annoying enough that we should just release
things.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Jul 15, 2021
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 16, 2021
@techknowlogick techknowlogick merged commit be46f24 into go-gitea:release/v1.14 Jul 16, 2021
@zeripath zeripath deleted the backport-16447-v1.14 branch July 16, 2021 00:26
zeripath added a commit that referenced this pull request Jul 16, 2021
@zeripath
Changelog for v1.14.5 (#16450)
62fa153 
Once #16449 is merged I think we should release 1.14.5. There are a couple of
security fixes and the broken #16268 is annoying enough that we should just release
things.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.5
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @techknowlogick @lafriks @GiteaBot