Serve raw files with the correct content types #15299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be optional and default off for the sake of security. See #8152 (comment). |
silverwind
reviewed
Apr 6, 2021
|
Thanks @silverwind. PR updated. |
Resolves go-gitea#8152. Signed-off-by: Trevor Slocum <trevor@rocketnine.space>
|
See #8152 (comment) for a better suggestion. |
|
While I can see merit in your suggestion, the changes in this PR could be explicitly enabled by users via a configuration option (as you originally suggested), with a warning stating the potential security implications. It would also coexist with custom content types when they are implemented (i.e., check custom content types before detecting a file's content type). Closing because the scope of the solution has grown beyond my interest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8152.
This is an alternative implementation to the existing PR for this issue.